Skip to content

[SPARKR]found some extra whitespace in the R tests #22896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shaneknapp wants to merge 1 commit into from
Closed

[SPARKR]found some extra whitespace in the R tests #22896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions R/pkg/tests/fulltests/test_sparkSQL_eager.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,30 +22,30 @@ context("test show SparkDataFrame when eager execution is enabled.")
test_that("eager execution is not enabled", {
# Start Spark session without eager execution enabled
sparkR.session(master = sparkRTestMaster, enableHiveSupport = FALSE)

df <- createDataFrame(faithful)
expect_is(df, "SparkDataFrame")
expected <- "eruptions:double, waiting:double"
expect_output(show(df), expected)

# Stop Spark session
sparkR.session.stop()
})

test_that("eager execution is enabled", {
# Start Spark session with eager execution enabled
sparkConfig <- list(spark.sql.repl.eagerEval.enabled = "true")

sparkR.session(master = sparkRTestMaster, enableHiveSupport = FALSE, sparkConfig = sparkConfig)

df <- createDataFrame(faithful)
expect_is(df, "SparkDataFrame")
expected <- paste0("(+---------+-------+\n",
"|eruptions|waiting|\n",
"+---------+-------+\n)*",
"(only showing top 20 rows)")
expect_output(show(df), expected)

# Stop Spark session
sparkR.session.stop()
})
Expand All @@ -55,9 +55,9 @@ test_that("eager execution is enabled with maxNumRows and truncate set", {
sparkConfig <- list(spark.sql.repl.eagerEval.enabled = "true",
spark.sql.repl.eagerEval.maxNumRows = as.integer(5),
spark.sql.repl.eagerEval.truncate = as.integer(2))

sparkR.session(master = sparkRTestMaster, enableHiveSupport = FALSE, sparkConfig = sparkConfig)

df <- arrange(createDataFrame(faithful), "waiting")
expect_is(df, "SparkDataFrame")
expected <- paste0("(+---------+-------+\n",
Expand All @@ -66,7 +66,7 @@ test_that("eager execution is enabled with maxNumRows and truncate set", {
"| 1.| 43|\n)*",
"(only showing top 5 rows)")
expect_output(show(df), expected)

# Stop Spark session
sparkR.session.stop()
})