Skip to content

[SPARK-1192][RESUBMIT]Missing document of some parameters in Spark Core - #2312

Closed
CodingCat wants to merge 16 commits into
apache:masterfrom
CodingCat:configuration
Closed

[SPARK-1192][RESUBMIT]Missing document of some parameters in Spark Core#2312
CodingCat wants to merge 16 commits into
apache:masterfrom
CodingCat:configuration

Conversation

@CodingCat

Copy link
Copy Markdown
Contributor

It's a resubmission of #85 according to @mateiz 's suggestion


Hi, @mateiz and @pwendell

I found that nearly all parameters in constructing actor system (AkkaUtil) are not documented...

IIRC, there was a PR which proposes that we should leave space for the user to configure the Akka system, is that still valid?

@CodingCat

Copy link
Copy Markdown
ContributorAuthor

ignore the first 6 parameters...they are duplicate with the ones in spark-standalone.md...

@SparkQA

Copy link
Copy Markdown

QA tests have started for PR 2312 at commit 9f4e2cd.

  • This patch merges cleanly.

@SparkQA

Copy link
Copy Markdown

QA tests have finished for PR 2312 at commit 9f4e2cd.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

Copy link
Copy Markdown

QA tests have started for PR 2312 at commit 1784b47.

  • This patch merges cleanly.

@SparkQA

Copy link
Copy Markdown

QA tests have finished for PR 2312 at commit 1784b47.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@CodingCatCodingCat changed the title [SPARK-1191][RESUBMIT]Missing document of some parameters in Spark Core[SPARK-1192][RESUBMIT]Missing document of some parameters in Spark CoreOct 13, 2014
@nchammas

Copy link
Copy Markdown
Contributor

@CodingCat This PR has gone stale. Do you want to update it?

@CodingCat

Copy link
Copy Markdown
ContributorAuthor

@nchammas this has been a long process (since my first submit in #85) , since most of the parameters are not frequently involved in the daily usage, I will close this one

Maybe we can update the doc for those missing parameters once we find some of them are useful

@nchammas

Copy link
Copy Markdown
Contributor

Okie doke. Sounds good to me.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@CodingCat@SparkQA@nchammas