Uh oh!
There was an error while loading. Please reload this page.
[SPARK-26212][Build][test-maven] Upgrade maven version to 3.6.0 - #23177
[SPARK-26212][Build][test-maven] Upgrade maven version to 3.6.0#23177kiszk wants to merge 2 commits into
Conversation
SparkQA
commented
Nov 29, 2018
Test build #99437 has finished for PR 23177 at commit
|
kiszk
commented
Nov 29, 2018
retest this please |
srowen
commented
Nov 29, 2018
That's fine but we need to also update build/mvn to download and use the same version. |
kiszk
commented
Nov 29, 2018
I thought that it is automatically done by |
SparkQA
commented
Nov 29, 2018
Test build #99464 has finished for PR 23177 at commit
|
srowen
commented
Nov 29, 2018
Ah, that's the second time I've forgotten this. Yes looks good to me. |
SparkQA
commented
Nov 29, 2018
Test build #4447 has finished for PR 23177 at commit
|
| <maven.compiler.source>${java.version}</maven.compiler.source> | ||
| <maven.compiler.target>${java.version}</maven.compiler.target> | ||
| <maven.version>3.5.4</maven.version> | ||
| <maven.version>3.6.0</maven.version> |
There was a problem hiding this comment.
@kiszk, I think we should update here as well https://github.com/apache/spark/blob/master/docs/building-spark.md#apache-maven (see #22781)
There was a problem hiding this comment.
That wouldn't hurt, though I suspect the project continues to build with Maven 3.5.4 for a long while.
There was a problem hiding this comment.
+1 for updating the doc, too.
HyukjinKwon
commented
Nov 30, 2018
adding @dongjoon-hyun |
dongjoon-hyun
commented
Nov 30, 2018
Thank you for pinging me, @HyukjinKwon . |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
LGTM except for the doc issue.
I also tested with Scala-2.11 Maven for safety. It looks okay.
Oh, @kiszk . Could you update AppVoyer script together? AppVoyer script still uses a static version number unlike with |
kiszk
commented
Dec 1, 2018
Sure, updated. Thanks for letting know them. |
SparkQA
commented
Dec 1, 2018
Test build #99538 has finished for PR 23177 at commit
|
srowen
commented
Dec 1, 2018
Merging to master. I've been using 3.6.0 on the command line for a while and it's fine. Note that if you use your local mvn in IntelliJ, it seems to have some incompatibility with the current latest 2018.13.1 release. It's no big deal, falling back to its internal 3.3.9 version works fine. |
## What changes were proposed in this pull request? This PR updates maven version from 3.5.4 to 3.6.0. The release note of the 3.6.0 is [here](https://maven.apache.org/docs/3.6.0/release-notes.html). From [the release note of the 3.6.0](https://maven.apache.org/docs/3.6.0/release-notes.html), the followings are new features: 1. There had been issues related to the project discoverytime which has been increased in previous version which influenced some of our users. 1. The output in the reactor summary has been improved. 1. There was an issue related to the classpath ordering. ## How was this patch tested? Existing tests Closesapache#23177 from kiszk/SPARK-26212. Authored-by: Kazuaki Ishizaki <ishizaki@jp.ibm.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
What changes were proposed in this pull request?
This PR updates maven version from 3.5.4 to 3.6.0. The release note of the 3.6.0 is here.
From the release note of the 3.6.0, the followings are new features:
How was this patch tested?
Existing tests