Skip to content

[FOLLOW-UP][SPARK-26065][SQL] Fix the Failure when having two Consecutive Hints - #23501

Closed
maryannxue wants to merge 1 commit into
apache:masterfrom
maryannxue:query-hint-followup
Closed

[FOLLOW-UP][SPARK-26065][SQL] Fix the Failure when having two Consecutive Hints#23501
maryannxue wants to merge 1 commit into
apache:masterfrom
maryannxue:query-hint-followup

Conversation

@maryannxue

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

This is to fix a bug in #23036, which would lead to an exception in case of two consecutive hints.

How was this patch tested?

Added a new test.

@dongjoon-hyun

dongjoon-hyun commented Jan 9, 2019

Copy link
Copy Markdown
Member

Hi, @maryannxue .
Although this is Spark 3.0 only change, could you file a new SPARK JIRA issue, please?
Also, please update the title. The title of followup PRs have better describe their own commit contents.

@gatorsmilegatorsmile changed the title [FOLLOW-UP][SPARK-26065][SQL] Change query hint from a LogicalPlan to a field[FOLLOW-UP][SPARK-26065][SQL] Fix the Failure when having two Consecutive HintsJan 9, 2019
@gatorsmile

Copy link
Copy Markdown
Member

I updated the title. Thanks! Merged to master.

@SparkQA

Copy link
Copy Markdown

Test build #100985 has finished for PR 23501 at commit a30c0bd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgitasfgit closed this in 2d01bccJan 9, 2019
jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
…tive Hints
## What changes were proposed in this pull request?
This is to fix a bug in apache#23036, which would lead to an exception in case of two consecutive hints.
## How was this patch tested?
Added a new test.
Closesapache#23501 from maryannxue/query-hint-followup.
Authored-by: maryannxue <maryannxue@apache.org>
Signed-off-by: gatorsmile <gatorsmile@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@maryannxue@dongjoon-hyun@gatorsmile@SparkQA