Skip to content

[SPARK-25935][SQL] Allow null rows for bad records from JSON parsers - #23543

Closed
MaxGekk wants to merge 1 commit into
apache:masterfrom
MaxGekk:return-nulls-from-json-parser
Closed

[SPARK-25935][SQL] Allow null rows for bad records from JSON parsers#23543
MaxGekk wants to merge 1 commit into
apache:masterfrom
MaxGekk:return-nulls-from-json-parser

Conversation

@MaxGekk

@MaxGekkMaxGekk commented Jan 14, 2019

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This PR reverts #22938 per discussion in #23325

Closes#23325

@MaxGekk

MaxGekk commented Jan 14, 2019

Copy link
Copy Markdown
MemberAuthor

@cloud-fan@HyukjinKwon@attilapiros Please, take a look at the PR.

@MaxGekkMaxGekk changed the title [SPARK-25935][SQL] Return null rows from JSON parser[SPARK-25935][SQL] Allow null rows for bad records from JSON/CSV parsersJan 14, 2019
@MaxGekk
MaxGekkforce-pushed the return-nulls-from-json-parser branch from 6574db0 to 69a4284CompareJanuary 15, 2019 00:00
@HyukjinKwon

Copy link
Copy Markdown
Member

Yup, I agree with it for now.

@SparkQA

Copy link
Copy Markdown

Test build #101209 has finished for PR 23543 at commit 6574db0.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

Copy link
Copy Markdown

Test build #101210 has finished for PR 23543 at commit 69a4284.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan

Copy link
Copy Markdown
Contributor

thanks, merging to master!

@bersprockets

Copy link
Copy Markdown
Contributor

Should the PR title be "Allow null rows for bad records from JSON parsers"?

@cloud-fancloud-fan changed the title [SPARK-25935][SQL] Allow null rows for bad records from JSON/CSV parsers[SPARK-25935][SQL] Allow null rows for bad records from JSON parsersJan 15, 2019
@cloud-fan

Copy link
Copy Markdown
Contributor

good catch! I've updated the title

jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?
This PR reverts apache#22938 per discussion in apache#23325Closesapache#23325Closesapache#23543 from MaxGekk/return-nulls-from-json-parser.
Authored-by: Maxim Gekk <max.gekk@gmail.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
@MaxGekk
MaxGekk deleted the return-nulls-from-json-parser branch August 17, 2019 13:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@MaxGekk@HyukjinKwon@SparkQA@cloud-fan@bersprockets