Uh oh!
There was an error while loading. Please reload this page.
[SPARK-26082][MESOS][FOLLOWUP][BRANCH-2.3] Add UT on fetcher cache option on MesosClusterScheduler - #23754
Closed
HeartSaVioR wants to merge 2 commits into
Closed
[SPARK-26082][MESOS][FOLLOWUP][BRANCH-2.3] Add UT on fetcher cache option on MesosClusterScheduler#23754HeartSaVioR wants to merge 2 commits into
HeartSaVioR wants to merge 2 commits into
Conversation
…sClusterScheduler This patch adds UT on testing SPARK-26082 to avoid regression. While apache#23743 reduces the possibility to make a similar mistake, the needed lines of code for adding tests are not that huge, so I guess it might be worth to add them. Newly added UTs. Test "supports setting fetcher cache" fails when apache#23743 is not applied and succeeds when apache#23743 is applied.
SparkQA
commented
Feb 9, 2019
Test build #102122 has finished for PR 23754 at commit
|
dongjoon-hyun
commented
Feb 9, 2019
Member
HeartSaVioR
commented
Feb 9, 2019
ContributorAuthor
My bad. I fixed the number (number being swapped at that time). |
| assert(networkInfos.get(0).getLabels.getLabels(1).getValue == "val2") | ||
| } | ||
| test("supports setting fetcher cache") { |
There was a problem hiding this comment.
Please add SPARK-26082 at the test case name.
| assert(uris.asScala.forall(_.getCache)) | ||
| } | ||
| test("supports disabling fetcher cache") { |
There was a problem hiding this comment.
Please add SPARK-26082 at the test case name.
dongjoon-hyun
commented
Feb 10, 2019
Member
I know this is the same with the patch on |
SparkQA
commented
Feb 10, 2019
Test build #102164 has finished for PR 23754 at commit
|
dongjoon-hyun
approved these changes
Feb 10, 2019
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM. Merged to branch-2.3.
dongjoon-hyun pushed a commit
that referenced
this pull request
Feb 10, 2019
…tion on MesosClusterScheduler ## What changes were proposed in this pull request? This patch adds UT on testing SPARK-26082 to avoid regression. While #23743 reduces the possibility to make a similar mistake, the needed lines of code for adding tests are not that huge, so I guess it might be worth to add them. ## How was this patch tested? Newly added UTs. Test "supports setting fetcher cache" fails when #23734 is not applied and succeeds when #23734 is applied. Closes#23754 from HeartSaVioR/SPARK-26082-branch-2.3. Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun
commented
Feb 10, 2019
Member
Thank you, @HeartSaVioR . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch adds UT on testing SPARK-26082 to avoid regression. While #23743 reduces the possibility to make a similar mistake, the needed lines of code for adding tests are not that huge, so I guess it might be worth to add them.
How was this patch tested?
Newly added UTs. Test "supports setting fetcher cache" fails when #23734 is not applied and succeeds when #23734 is applied.