[SPARK-1087] Move python traceback utilities into new traceback_utils.py file.

[staple]

Also made some cosmetic cleanups.

[SparkQA]

Can one of the admins verify this patch?

[JoshRosen]

Jenkins, this is ok to test.

[SparkQA]

QA tests have started for PR 2385 at commit 10ba6e1.

• This patch merges cleanly.

[jyotiska]

LGTM.

[SparkQA]

QA tests have finished for PR 2385 at commit 10ba6e1.

• This patch fails unit tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • class JavaStackTrace(object):

[staple]

Hi, the above failure in NetworkReceiverSuite.scala seems like it may be unrelated to this patch. That test also passed when I ran locally.

[SparkQA]

QA tests have started for PR 2385 at commit 10ba6e1.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 2385 at commit 10ba6e1.

• This patch passes unit tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • class JavaStackTrace(object):

[davies]

it's better to only call extract_concise_traceback() once, such as:

self._callsite = extract_concise_traceback()
if self._callsite is None:
xxxx

[davies]

LGTM, just one minor comment, it's not must to have.

[staple]

Looks like I also need to put JavaStackTrace here instead of SparkContext.

[davies]

They are just internal interfaces, so it's fine to not have all here. If having, it should be JavaStackTrace

[staple]

Hi - I addressed the review comments and made some additional cosmetic changes.

[SparkQA]

QA tests have started for PR 2385 at commit 7b3bb13.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 2385 at commit 7b3bb13.

• This patch passes unit tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • class SCCallSiteSync(object):

[JoshRosen]

This looks good to me, so I'm going to merge it. Thanks!

[staple]

Great! Thanks to all the reviewers.