Uh oh!
There was an error while loading. Please reload this page.
[MINOR][BUILD] Update all checkstyle dtd to use "https://checkstyle.org" - #23887
Closed
HeartSaVioR wants to merge 1 commit into
Closed
[MINOR][BUILD] Update all checkstyle dtd to use "https://checkstyle.org"#23887HeartSaVioR wants to merge 1 commit into
HeartSaVioR wants to merge 1 commit into
Conversation
cloud-fan
commented
Feb 25, 2019
Contributor
ok to test |
cloud-fan
commented
Feb 25, 2019
Contributor
srowen
approved these changes
Feb 25, 2019
kiszk
commented
Feb 25, 2019
Member
LGTM, pending Jenkins |
SparkQA
commented
Feb 25, 2019
Test build #102752 has finished for PR 23887 at commit
|
SparkQA
commented
Feb 25, 2019
Test build #102753 has finished for PR 23887 at commit
|
vanzin
commented
Feb 25, 2019
Contributor
Merging to master / 2.4 / 2.3. |
vanzin pushed a commit
that referenced
this pull request
Feb 25, 2019
## What changes were proposed in this pull request? Below build failed with Java checkstyle test, but instead of violation it shows FileNotFound on dtd file. https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102751/ Looks like the link of dtd file is dead `http://www.puppycrawl.com/dtds/configuration_1_3.dtd`. This patch updates the dtd link to "https://checkstyle.org/dtds/" given checkstyle repository also updated the URL path. checkstyle/checkstyle#5601 ## How was this patch tested? Checked the new links. Closes#23887 from HeartSaVioR/java-checkstyle-dtd-change-url. Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com> (cherry picked from commit c5de804) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
vanzin pushed a commit
that referenced
this pull request
Feb 25, 2019
## What changes were proposed in this pull request? Below build failed with Java checkstyle test, but instead of violation it shows FileNotFound on dtd file. https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102751/ Looks like the link of dtd file is dead `http://www.puppycrawl.com/dtds/configuration_1_3.dtd`. This patch updates the dtd link to "https://checkstyle.org/dtds/" given checkstyle repository also updated the URL path. checkstyle/checkstyle#5601 ## How was this patch tested? Checked the new links. Closes#23887 from HeartSaVioR/java-checkstyle-dtd-change-url. Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com> (cherry picked from commit c5de804) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
HeartSaVioR
commented
Feb 25, 2019
ContributorAuthor
Thanks all for reviewing and merging! |
kai-chi pushed a commit
to kai-chi/spark
that referenced
this pull request
Jul 23, 2019
## What changes were proposed in this pull request? Below build failed with Java checkstyle test, but instead of violation it shows FileNotFound on dtd file. https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102751/ Looks like the link of dtd file is dead `http://www.puppycrawl.com/dtds/configuration_1_3.dtd`. This patch updates the dtd link to "https://checkstyle.org/dtds/" given checkstyle repository also updated the URL path. checkstyle/checkstyle#5601 ## How was this patch tested? Checked the new links. Closesapache#23887 from HeartSaVioR/java-checkstyle-dtd-change-url. Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com> (cherry picked from commit c5de804) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
kai-chi pushed a commit
to kai-chi/spark
that referenced
this pull request
Jul 25, 2019
## What changes were proposed in this pull request? Below build failed with Java checkstyle test, but instead of violation it shows FileNotFound on dtd file. https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102751/ Looks like the link of dtd file is dead `http://www.puppycrawl.com/dtds/configuration_1_3.dtd`. This patch updates the dtd link to "https://checkstyle.org/dtds/" given checkstyle repository also updated the URL path. checkstyle/checkstyle#5601 ## How was this patch tested? Checked the new links. Closesapache#23887 from HeartSaVioR/java-checkstyle-dtd-change-url. Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com> (cherry picked from commit c5de804) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
kai-chi pushed a commit
to kai-chi/spark
that referenced
this pull request
Aug 1, 2019
## What changes were proposed in this pull request? Below build failed with Java checkstyle test, but instead of violation it shows FileNotFound on dtd file. https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102751/ Looks like the link of dtd file is dead `http://www.puppycrawl.com/dtds/configuration_1_3.dtd`. This patch updates the dtd link to "https://checkstyle.org/dtds/" given checkstyle repository also updated the URL path. checkstyle/checkstyle#5601 ## How was this patch tested? Checked the new links. Closesapache#23887 from HeartSaVioR/java-checkstyle-dtd-change-url. Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com> (cherry picked from commit c5de804) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Below build failed with Java checkstyle test, but instead of violation it shows FileNotFound on dtd file.
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102751/
Looks like the link of dtd file is dead
http://www.puppycrawl.com/dtds/configuration_1_3.dtd.This patch updates the dtd link to "https://checkstyle.org/dtds/" given checkstyle repository also updated the URL path.
checkstyle/checkstyle#5601
How was this patch tested?
Checked the new links.