Uh oh!
There was an error while loading. Please reload this page.
[SPARK-2594][SQL] Add CACHE TABLE <name> AS SELECT ... (Updated as per review comments) - #2390
Closed
ravipesala wants to merge 12 commits into
Closed
[SPARK-2594][SQL] Add CACHE TABLE <name> AS SELECT ... (Updated as per review comments)#2390ravipesala wants to merge 12 commits into
ravipesala wants to merge 12 commits into
Conversation
This feature allows user to add cache table from the select query. Example : ADD CACHE TABLE <tableName> AS SELECT * FROM TEST_TABLE. Spark takes this type of SQL as command and it does eager caching. It can be executed from SQLContext and HiveContext. Signed-off-by: ravipesala <ravindra.pesala@huawei.com>
This feature allows user to add cache table from the select query. Example : ADD CACHE TABLE <tableName> AS SELECT * FROM TEST_TABLE. Spark takes this type of SQL as command and it does eager caching. It can be executed from SQLContext and HiveContext. Signed-off-by: ravipesala <ravindra.pesala@huawei.com>
Add-Cache-table-as
SparkQA
commented
Sep 14, 2014
Can one of the admins verify this patch? |
Contributor
There was a problem hiding this comment.
I think opt(AS ~ select) would be better here? Otherwise illegal statements like CACHE TABLE AS and CACHE TABLE SELECT * FROM t would both be allowed.
Contributor
There was a problem hiding this comment.
Actually opt(AS ~> select), since we don't care the semantic value returned by AS.
ContributorAuthor
There was a problem hiding this comment.
Thank you for your comments. Yes,It is better to add as opt(AS ~> select)
ravipesala
commented
Sep 15, 2014
ContributorAuthor
As there is a confusion in rebasing, I have created a new pull request #2397 rebased with master and also fixed the review comments raised here. |
liancheng
commented
Sep 17, 2014
Contributor
Would you mind to close this PR since #2397 was opened as a replacement? |
ravipesala
commented
Sep 18, 2014
ContributorAuthor
OK. Closing this PR |
asfgit pushed a commit
that referenced
this pull request
Sep 19, 2014
This feature allows user to add cache table from the select query. Example : ```CACHE TABLE testCacheTable AS SELECT * FROM TEST_TABLE``` Spark takes this type of SQL as command and it does lazy caching just like ```SQLContext.cacheTable```, ```CACHE TABLE <name>``` does. It can be executed from both SQLContext and HiveContext. Recreated the pull request after rebasing with master.And fixed all the comments raised in previous pull requests. #2381#2390 Author : ravipesala ravindra.pesalahuawei.com Author: ravipesala <ravindra.pesala@huawei.com> Closes#2397 from ravipesala/SPARK-2594 and squashes the following commits: a5f0beb [ravipesala] Simplified the code as per Admin comment. 8059cd2 [ravipesala] Changed the behaviour from eager caching to lazy caching. d6e469d [ravipesala] Code review comments by Admin are handled. c18aa38 [ravipesala] Merge remote-tracking branch 'remotes/ravipesala/Add-Cache-table-as' into SPARK-2594394d5ca [ravipesala] Changed style fb1759b [ravipesala] Updated as per Admin comments 8c9993c [ravipesala] Changed the style d8b37b2 [ravipesala] Updated as per the comments by Admin bc0bffc [ravipesala] Merge remote-tracking branch 'ravipesala/Add-Cache-table-as' into Add-Cache-table-as e3265d0 [ravipesala] Updated the code as per the comments by Admin in pull request. 724b9db [ravipesala] Changed style aaf5b59 [ravipesala] Added comment dc33895 [ravipesala] Updated parser to support add cache table command b5276b2 [ravipesala] Updated parser to support add cache table command eebc0c1 [ravipesala] Add CACHE TABLE <name> AS SELECT ... 6758f80 [ravipesala] Changed style 7459ce3 [ravipesala] Added comment 13c8e27 [ravipesala] Updated parser to support add cache table command 4e858d8 [ravipesala] Updated parser to support add cache table command b803fc8 [ravipesala] Add CACHE TABLE <name> AS SELECT ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated as per the review comments of Admin.
Previous pull request is #2381