Skip to content

[SPARK-25863][SPARK-21871][SQL] Check if code size statistics is empty or not in updateAndGetCompilationStats#23947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maropu wants to merge 1 commit into from
Closed

[SPARK-25863][SPARK-21871][SQL] Check if code size statistics is empty or not in updateAndGetCompilationStats #23947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...lyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1352,7 +1352,11 @@ object CodeGenerator extends Logging {
}
}.flatten

codeSizes.max
if (codeSizes.nonEmpty) {
codeSizes.max
} else {
0

@gatorsmilegatorsmileMar 4, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test case? cc @rednaxelafx

@maropumaropuMar 4, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, no. I tried to add tests though, I couldn't find an input for this issue... Any idea, Kris?

@TagarTagarMar 5, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my 2 cents - We only have this issue on our most heavy prod jobs with a lot of columns and a lot of partitions.. I wonder if Spark struggles to collect some stats in this case, and then this becomes zero. We don't have a reproducer as it again only happens on our heaviest prod jobs.. but it does happen consistently when we're over a certain limit of number of columns or number of partitions/tasks, or both. Thanks.

}
}

/**
Expand Down