Uh oh!
There was an error while loading. Please reload this page.
[SPARK-27074][SQL][test-hadoop3.2][test-maven] Hive 3.1 metastore support HiveClientImpl.runHive - #23992
[SPARK-27074][SQL][test-hadoop3.2][test-maven] Hive 3.1 metastore support HiveClientImpl.runHive#23992wangyum wants to merge 7 commits into
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
SparkQA
commented
Mar 6, 2019
Test build #103099 has finished for PR 23992 at commit
|
Uh oh!
There was an error while loading. Please reload this page.
SparkQA
commented
May 12, 2019
Test build #105341 has finished for PR 23992 at commit
|
wangyum
commented
May 13, 2019
Uh oh!
There was an error while loading. Please reload this page.
SparkQA
commented
May 13, 2019
Test build #105359 has finished for PR 23992 at commit
|
| // But skip Hive 3.1 because of SPARK-27074. | ||
| if (version == "2.3") { | ||
| if (version == "2.3" || version == "3.1") { | ||
| val disableRewrite = if (version == "2.3") "" else "DISABLE REWRITE" |
There was a problem hiding this comment.
Could you add a comment about the reason why we use DISABLE REWRITE in Hive 3.x?
There was a problem hiding this comment.
SparkQA
commented
May 14, 2019
Test build #105385 has finished for PR 23992 at commit
|
wangyum
commented
May 15, 2019
bin/spark-shell --conf spark.sql.hive.metastore.version=3.1.1 --conf spark.sql.hive.metastore.jars=maven |
SparkQA
commented
May 16, 2019
Test build #105454 has finished for PR 23992 at commit
|
dongjoon-hyun
commented
May 20, 2019
Retest this please. |
SparkQA
commented
May 20, 2019
Test build #105550 has finished for PR 23992 at commit
|
wangyum
commented
May 20, 2019
retest this please |
SparkQA
commented
May 20, 2019
Test build #105559 has finished for PR 23992 at commit
|
dongjoon-hyun
commented
May 26, 2019
Retest this please. |
dongjoon-hyun
commented
May 26, 2019
Retest this please. |
SparkQA
commented
May 26, 2019
Test build #105791 has finished for PR 23992 at commit
|
SparkQA
commented
May 26, 2019
Test build #105792 has finished for PR 23992 at commit
|
wangyum
commented
May 26, 2019
Retest this please. |
SparkQA
commented
May 26, 2019
Test build #105795 has finished for PR 23992 at commit
|
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @wangyum .
Merged to master.
What changes were proposed in this pull request?
Hive 3.1.1's
CommandProcessorhave 2 changes:spark/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
Lines 736 to 742 in 02bbe97
We can disable
hive.query.reexecution.enabledto workaround this change.Driver.close()function return type. We can workaround it bydriver.getClass.getMethod("close").invoke(driver)So Hive 3.1 metastore could support
HiveClientImpl.runHiveafter this pr.How was this patch tested?
unit tests