Uh oh!
There was an error while loading. Please reload this page.
[SPARK-27215][CORE] Correct the kryo configurations - #24156
Conversation
LantaoJin
commented
Mar 20, 2019
@vanzin@squito@gatorsmile, could you have a time to review this? |
attilapiros
left a comment
There was a problem hiding this comment.
LGTM
I have checked the typo was introduced by #23532 which went into 3.0.0-SNAPSHOT and anyway the whole Kryo pool (along with this config) was introduced only in 3.0.0-SNAPSHOT.
Moreover there is no more reference to the incorrect spelling:
attilapiros@apiros-MBP ~/github/spark (pr/24156) $ find . \( -name "*.scala" -or -name "*.java" \) -exec grep -i "kyro" \{} \; -print
attilapiros@apiros-MBP ~/github/spark (pr/24156) $
jiangxb1987
commented
Mar 20, 2019
Does this change means the previous config key will no longer be recognized? |
vanzin
commented
Mar 20, 2019
The "previous" config key never existed, it was a typo in a recent change. |
jiangxb1987
commented
Mar 20, 2019
Thanks, sounds good! |
dongjoon-hyun
commented
Mar 20, 2019
cc @HeartSaVioR |
HeartSaVioR
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing my missed spots.
SparkQA
commented
Mar 20, 2019
Test build #4642 has finished for PR 24156 at commit
|
vanzin
commented
Mar 20, 2019
Merging to master. |
What changes were proposed in this pull request?
kyro should be kryo
How was this patch tested?
no need