Skip to content

[SPARK-24102][ML][MLLIB][PYSPARK][FOLLOWUP] Added weight column to pyspark API for regression evaluator and metrics - #24197

Closed
imatiach-msft wants to merge 1 commit into
apache:masterfrom
imatiach-msft:ilmat/regressor-eval-python
Closed

[SPARK-24102][ML][MLLIB][PYSPARK][FOLLOWUP] Added weight column to pyspark API for regression evaluator and metrics#24197
imatiach-msft wants to merge 1 commit into
apache:masterfrom
imatiach-msft:ilmat/regressor-eval-python

Conversation

@imatiach-msft

@imatiach-msftimatiach-msft commented Mar 25, 2019

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Followup to PR #17085
This PR adds the weight column to the pyspark side, which was already added to the scala API.
The PR also undoes a name change in the scala side corresponding to a change in another similar PR as noted here:
#17084 (comment)

How was this patch tested?

This patch adds python tests for the changes to the pyspark API.

Please review http://spark.apache.org/contributing.html before opening a pull request.

@SparkQA

Copy link
Copy Markdown

Test build #103885 has finished for PR 24197 at commit b26b0f5.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class RegressionEvaluator(JavaEvaluator, HasLabelCol, HasPredictionCol, HasWeightCol,

@imatiach-msft
imatiach-msftforce-pushed the ilmat/regressor-eval-python branch from b26b0f5 to 494e8aaCompareMarch 25, 2019 03:05
@SparkQA

Copy link
Copy Markdown

Test build #103886 has finished for PR 24197 at commit 494e8aa.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class RegressionEvaluator(JavaEvaluator, HasLabelCol, HasPredictionCol, HasWeightCol,

@srowensrowen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, yeah seems consistent given the other PRs

@imatiach-msft
imatiach-msftforce-pushed the ilmat/regressor-eval-python branch 2 times, most recently from d050f32 to f659fb2CompareMarch 25, 2019 04:47
@SparkQA

Copy link
Copy Markdown

Test build #103891 has finished for PR 24197 at commit d050f32.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class RegressionEvaluator(JavaEvaluator, HasLabelCol, HasPredictionCol, HasWeightCol,

@SparkQA

Copy link
Copy Markdown

Test build #103893 has finished for PR 24197 at commit f659fb2.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class RegressionEvaluator(JavaEvaluator, HasLabelCol, HasPredictionCol, HasWeightCol,

@HyukjinKwon

Copy link
Copy Markdown
Member

retest this please

@SparkQA

Copy link
Copy Markdown

Test build #103898 has finished for PR 24197 at commit f659fb2.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class RegressionEvaluator(JavaEvaluator, HasLabelCol, HasPredictionCol, HasWeightCol,

…spark API for regression evaluator and metrics
@imatiach-msft
imatiach-msftforce-pushed the ilmat/regressor-eval-python branch from f659fb2 to 4cb2137CompareMarch 26, 2019 02:35
@SparkQA

Copy link
Copy Markdown

Test build #103939 has finished for PR 24197 at commit 4cb2137.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class RegressionEvaluator(JavaEvaluator, HasLabelCol, HasPredictionCol, HasWeightCol,

@imatiach-msft

Copy link
Copy Markdown
ContributorAuthor

retest this please

@SparkQA

Copy link
Copy Markdown

Test build #103945 has finished for PR 24197 at commit 4cb2137.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class RegressionEvaluator(JavaEvaluator, HasLabelCol, HasPredictionCol, HasWeightCol,

@srowen

Copy link
Copy Markdown
Member

Merged to master

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@imatiach-msft@SparkQA@HyukjinKwon@srowen