Uh oh!
There was an error while loading. Please reload this page.
[SPARK-26856][PYSPARK][FOLLOWUP] Fix UT failure due to wrong patterns for Kinesis assembly - #24268
[SPARK-26856][PYSPARK][FOLLOWUP] Fix UT failure due to wrong patterns for Kinesis assembly#24268dongjoon-hyun wants to merge 3 commits into
Conversation
dongjoon-hyun
commented
Apr 2, 2019
cc @HyukjinKwon and @gaborgsomogyi . |
HyukjinKwon
commented
Apr 2, 2019
Thanks for catching this. |
dongjoon-hyun
commented
Apr 2, 2019
Thank you for review and approval, @HyukjinKwon . |
SparkQA
commented
Apr 2, 2019
Test build #104178 has finished for PR 24268 at commit
|
HyukjinKwon
commented
Apr 2, 2019
Hey @dongjoon-hyun, just to doubly sure, can you check Avro ones as well? |
dongjoon-hyun
commented
Apr 2, 2019
Ah, thank you so much, @HyukjinKwon . |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
SparkQA
commented
Apr 2, 2019
Test build #104181 has finished for PR 24268 at commit
|
SparkQA
commented
Apr 2, 2019
Test build #104182 has finished for PR 24268 at commit
|
HyukjinKwon
commented
Apr 2, 2019
Merged to master. |
dongjoon-hyun
commented
Apr 2, 2019
Thank you for review and merging, @HyukjinKwon ! |
gaborgsomogyi
commented
Apr 2, 2019
Late LGTM, thank you @dongjoon-hyun for fixing this. |
What changes were proposed in this pull request?
After SPARK-26856,
KinesisPython UT fails withFound multiple JARsexception due to a wrong pattern.It's because the pattern was changed in a wrong way.
Original
After SPARK-26856
The actual kinesis assembly jar files look like the followings.
SBT Build
MAVEN Build
In addition, after SPARK-26856, the utility function
search_jaris shared to findavrojar files which are identical for bothsbtandmvn. To sum up, The current jar pattern parameter cannot handle bothkinesisandavrojars. This PR splits the single pattern into two patterns.How was this patch tested?
Manual. Please note that this will remove only
Found multiple JARsexception. Kinesis tests need more configurations to run locally.