Uh oh!
There was an error while loading. Please reload this page.
[SPARK-27338][CORE][FOLLOWUP] remove trailing space - #24289
Closed
cloud-fan wants to merge 1 commit into
Closed
Conversation
cloud-fan
commented
Apr 4, 2019
ContributorAuthor
Contributor
Interesting. Somehow I missed it. |
cloud-fan
commented
Apr 4, 2019
ContributorAuthor
since it has passed the code style check, I'm merging it, thanks! |
dongjoon-hyun
commented
Apr 4, 2019
Member
Hi, @cloud-fan . |
cloud-fan added a commit
that referenced
this pull request
Apr 4, 2019
## What changes were proposed in this pull request? #24265 breaks the lint check, because it has trailing space. (not sure why it passed jenkins). This PR fixes it. ## How was this patch tested? N/A Closes#24289 from cloud-fan/fix. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
cloud-fan added a commit
that referenced
this pull request
Apr 4, 2019
## What changes were proposed in this pull request? #24265 breaks the lint check, because it has trailing space. (not sure why it passed jenkins). This PR fixes it. ## How was this patch tested? N/A Closes#24289 from cloud-fan/fix. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
cloud-fan
commented
Apr 4, 2019
ContributorAuthor
thanks for reminding! backported to 2.4/2.3 |
SparkQA
commented
Apr 4, 2019
Test build #104268 has finished for PR 24289 at commit
|
dongjoon-hyun
commented
Apr 4, 2019
Member
Thanks! |
kai-chi pushed a commit
to kai-chi/spark
that referenced
this pull request
Jul 23, 2019
## What changes were proposed in this pull request? apache#24265 breaks the lint check, because it has trailing space. (not sure why it passed jenkins). This PR fixes it. ## How was this patch tested? N/A Closesapache#24289 from cloud-fan/fix. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
kai-chi pushed a commit
to kai-chi/spark
that referenced
this pull request
Jul 25, 2019
## What changes were proposed in this pull request? apache#24265 breaks the lint check, because it has trailing space. (not sure why it passed jenkins). This PR fixes it. ## How was this patch tested? N/A Closesapache#24289 from cloud-fan/fix. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
kai-chi pushed a commit
to kai-chi/spark
that referenced
this pull request
Aug 1, 2019
## What changes were proposed in this pull request? apache#24265 breaks the lint check, because it has trailing space. (not sure why it passed jenkins). This PR fixes it. ## How was this patch tested? N/A Closesapache#24289 from cloud-fan/fix. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#24265 breaks the lint check, because it has trailing space. (not sure why it passed jenkins). This PR fixes it.
How was this patch tested?
N/A