Uh oh!
There was an error while loading. Please reload this page.
[SPARK-27580][SQL] Implement doCanonicalize in BatchScanExec for comparing query plan results - #24475
Closed
gengliangwang wants to merge 2 commits into
Closed
[SPARK-27580][SQL] Implement doCanonicalize in BatchScanExec for comparing query plan results#24475gengliangwang wants to merge 2 commits into
doCanonicalize in BatchScanExec for comparing query plan results#24475gengliangwang wants to merge 2 commits into
Conversation
gengliangwang
commented
Apr 26, 2019
MemberAuthor
SparkQA
commented
Apr 26, 2019
Test build #104950 has finished for PR 24475 at commit
|
SparkQA
commented
Apr 26, 2019
Test build #104945 has finished for PR 24475 at commit
|
cloud-fan
commented
Apr 29, 2019
Contributor
thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The method
QueryPlan.sameResultis used for comparing logical plans in order to:Currently the method
sameReusltalways return false forBatchScanExec. We should fix it by implementingdoCanonicalizefor the node.How was this patch tested?
Unit test