Skip to content

[SPARK-27276][PYTHON][DOCS][FOLLOW-UP] Update documentation about Arrow version in PySpark as well - #24504

Closed
HyukjinKwon wants to merge 1 commit into
apache:masterfrom
HyukjinKwon:SPARK-27276-followup
Closed

[SPARK-27276][PYTHON][DOCS][FOLLOW-UP] Update documentation about Arrow version in PySpark as well#24504
HyukjinKwon wants to merge 1 commit into
apache:masterfrom
HyukjinKwon:SPARK-27276-followup

Conversation

@HyukjinKwon

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Looks updating documentation from 0.8.0 to 0.12.1 was missed.

How was this patch tested?

N/A

@HyukjinKwon

Copy link
Copy Markdown
MemberAuthor

cc @BryanCutler

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realised that other Arrow optimization might likely be placed in other places .. :).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. The filename is sql-pyspark...

@SparkQA

Copy link
Copy Markdown

Test build #105055 has finished for PR 24504 at commit 275a4ef.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viiryaviirya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

There is another section:

Supported SQL Types
Currently, all Spark SQL data types are supported by Arrow-based conversion except MapType, ArrayType of TimestampType, and nested StructType. BinaryType is supported only when installed PyArrow is equal to or higher than 0.10.0.

As currently supported version is 0.12.1, the last sentence looks redundant?

@HyukjinKwon

Copy link
Copy Markdown
MemberAuthor

Yea, thanks for checking it.

@SparkQA

Copy link
Copy Markdown

Test build #105058 has finished for PR 24504 at commit 3482d31.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
HyukjinKwonforce-pushed the SPARK-27276-followup branch from 11a50df to ffdb362CompareMay 1, 2019 14:42
@SparkQA

Copy link
Copy Markdown

Test build #105061 has finished for PR 24504 at commit ffdb362.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwonHyukjinKwon changed the title [SPARK-27276][DOCS][FOLLOW-UP] Update documentation about Arrow version in PySpark as well[SPARK-27276][PYTHON][DOCS][FOLLOW-UP] Update documentation about Arrow version in PySpark as wellMay 1, 2019

@BryanCutlerBryanCutler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BryanCutler

Copy link
Copy Markdown
Member

merged to master, thanks @HyukjinKwon !

@HyukjinKwon
HyukjinKwon deleted the SPARK-27276-followup branch March 3, 2020 01:18
rshkv pushed a commit to palantir/spark that referenced this pull request May 17, 2020
…ow version in PySpark as well
## What changes were proposed in this pull request?
Looks updating documentation from 0.8.0 to 0.12.1 was missed.
## How was this patch tested?
N/A
Closesapache#24504 from HyukjinKwon/SPARK-27276-followup.
Authored-by: HyukjinKwon <gurwls223@apache.org>
Signed-off-by: Bryan Cutler <cutlerb@gmail.com>
rshkv pushed a commit to palantir/spark that referenced this pull request May 18, 2020
* [SPARK-27276][PYTHON][SQL] Increase minimum version of pyarrow to 0.12.1 and remove prior workarounds
This increases the minimum support version of pyarrow to 0.12.1 and removes workarounds in pyspark to remain compatible with prior versions. This means that users will need to have at least pyarrow 0.12.1 installed and available in the cluster or an `ImportError` will be raised to indicate an upgrade is needed.
Existing tests using:
Python 2.7.15, pyarrow 0.12.1, pandas 0.24.2
Python 3.6.7, pyarrow 0.12.1, pandas 0.24.0
Closesapache#24298 from BryanCutler/arrow-bump-min-pyarrow-SPARK-27276.
Authored-by: Bryan Cutler <cutlerb@gmail.com>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
* Fix pandas infer_dtype warning
* [SPARK-27276][PYTHON][DOCS][FOLLOW-UP] Update documentation about Arrow version in PySpark as well
## What changes were proposed in this pull request?
Looks updating documentation from 0.8.0 to 0.12.1 was missed.
## How was this patch tested?
N/A
Closesapache#24504 from HyukjinKwon/SPARK-27276-followup.
Authored-by: HyukjinKwon <gurwls223@apache.org>
Signed-off-by: Bryan Cutler <cutlerb@gmail.com>
Co-authored-by: Bryan Cutler <cutlerb@gmail.com>
Co-authored-by: HyukjinKwon <gurwls223@apache.org>
rshkv pushed a commit to palantir/spark that referenced this pull request May 21, 2020
…ow version in PySpark as well
## What changes were proposed in this pull request?
Looks updating documentation from 0.8.0 to 0.12.1 was missed.
## How was this patch tested?
N/A
Closesapache#24504 from HyukjinKwon/SPARK-27276-followup.
Authored-by: HyukjinKwon <gurwls223@apache.org>
Signed-off-by: Bryan Cutler <cutlerb@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@HyukjinKwon@SparkQA@BryanCutler@viirya@srowen@dongjoon-hyun