Uh oh!
There was an error while loading. Please reload this page.
[SPARK-3597][Mesos] Implement killTask. - #2453
Conversation
rxin
commented
Sep 19, 2014
Sorry for asking - but have you tested this on a real cluster? |
rxin
commented
Sep 19, 2014
Oh and thanks for doing this! |
brndnmtthws
commented
Sep 19, 2014
I did indeed test it, and it worked as expected. |
SparkQA
commented
Sep 19, 2014
Can one of the admins verify this patch? |
andrewor14
commented
Sep 19, 2014
ok to test |
andrewor14
commented
Sep 19, 2014
There is a related PR #1940 |
andrewor14
commented
Sep 26, 2014
test this please |
SparkQA
commented
Sep 26, 2014
QA tests have started for PR 2453 at commit
|
SparkQA
commented
Sep 26, 2014
QA tests have finished for PR 2453 at commit
|
AmplabJenkins
commented
Sep 26, 2014
Test FAILed. |
brndnmtthws
commented
Sep 26, 2014
Build error appears to be unrelated to my patch. |
JoshRosen
commented
Sep 26, 2014
Build failure is my fault, due to merging #2351. I've reverted it and re-triggered your unit tests. |
brndnmtthws
commented
Sep 26, 2014
Okay, I'll rebase. |
The MesosSchedulerBackend did not previously implement `killTask`, resulting in an exception.
40c4478 to
23ddcdcCompareSparkQA
commented
Sep 26, 2014
QA tests have started for PR 2453 at commit
|
SparkQA
commented
Sep 26, 2014
QA tests have started for PR 2453 at commit
|
SparkQA
commented
Sep 26, 2014
QA tests have finished for PR 2453 at commit
|
SparkQA
commented
Sep 26, 2014
QA tests have finished for PR 2453 at commit
|
AmplabJenkins
commented
Sep 26, 2014
Test PASSed. |
brndnmtthws
commented
Oct 2, 2014
andrewor14
commented
Oct 2, 2014
LGTM, but I'm no expert on the mesos integration. @tnachen any comments? |
JoshRosen
commented
Oct 4, 2014
This looks good to me. I tested this patch against Mesos 0.20.1 running in Docker with a modified version of a test from Spark's JobCancellationSuite . @tnachen commented on this over at #1940 (comment):
|
andrewor14
commented
Oct 5, 2014
Alright, thanks for testing @JoshRosen and @brndnmtthws. I'm merging this into master and 1.1. |
The MesosSchedulerBackend did not previously implement `killTask`, resulting in an exception. Author: Brenden Matthews <brenden@diddyinc.com> Closes#2453 from brndnmtthws/implement-killtask and squashes the following commits: 23ddcdc [Brenden Matthews] [SPARK-3597][Mesos] Implement `killTask`. (cherry picked from commit 32fad42) Signed-off-by: Andrew Or <andrewor14@gmail.com>

The MesosSchedulerBackend did not previously implement
killTask,resulting in an exception.