Uh oh!
There was an error while loading. Please reload this page.
[MINOR][SS]Remove duplicate 'add' in comment of StructuredSessionization. - #24589
Closed
beliefer wants to merge 3 commits into
Closed
[MINOR][SS]Remove duplicate 'add' in comment of StructuredSessionization.#24589beliefer wants to merge 3 commits into
StructuredSessionization.#24589beliefer wants to merge 3 commits into
Conversation
StructuredSessionization.StructuredSessionization.SparkQA
commented
May 13, 2019
Test build #105347 has finished for PR 24589 at commit
|
HyukjinKwon
commented
May 13, 2019
Member
It's fine. but mind taking another look and see if there are some more typos to fix? I am sure there are more. |
beliefer
commented
May 14, 2019
ContributorAuthor
Thank you. I found another two typos, but I'm not sure. |
SparkQA
commented
May 14, 2019
Test build #105371 has finished for PR 24589 at commit
|
Member
There was a problem hiding this comment.
Hm, other two occurrences are fine.
I'll just get this in - let's just keep the and typo fix only in this PR
- // Sessionize the events. Track number of events, start and end timestamps of session, and+ // Sessionize the events. Track number of events, start and end timestamps of session,ContributorAuthor
There was a problem hiding this comment.
Hm, other two occurrences are fine.
I'll just get this in - let's just keep the
andtypo fix only in this PR- // Sessionize the events. Track number of events, start and end timestamps of session, and+ // Sessionize the events. Track number of events, start and end timestamps of session,
I find another type timestamps and changed to time stamps.
Is Sessionize a typo?
SparkQA
commented
May 14, 2019
Test build #105378 has finished for PR 24589 at commit
|
| } | ||
| // Sessionize the events. Track number of events, start and end timestamps of session, and | ||
| // Sessionize the events. Track number of events, start and end time stamps of session, |
ContributorAuthor
There was a problem hiding this comment.
I believe timestamp is fine ..
Is Sessionize a typo?
ContributorAuthor
There was a problem hiding this comment.
OK. I have recovered timestamps.
recover timestamps
SparkQA
commented
May 15, 2019
Test build #105403 has finished for PR 24589 at commit
|
HyukjinKwon pushed a commit
that referenced
this pull request
May 15, 2019
…ation`. ## What changes were proposed in this pull request? `StructuredSessionization` comment contains duplicate 'add', I think it should be changed. ## How was this patch tested? Exists UT. Closes#24589 from beliefer/remove-duplicate-add-in-comment. Lead-authored-by: gengjiaan <gengjiaan@360.cn> Co-authored-by: Jiaan Geng <beliefer@163.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 7dd2dd5) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
HyukjinKwon
commented
May 15, 2019
Member
Merged to master, branch-2.4 and branch-2.3 |
HyukjinKwon pushed a commit
that referenced
this pull request
May 15, 2019
…ation`. ## What changes were proposed in this pull request? `StructuredSessionization` comment contains duplicate 'add', I think it should be changed. ## How was this patch tested? Exists UT. Closes#24589 from beliefer/remove-duplicate-add-in-comment. Lead-authored-by: gengjiaan <gengjiaan@360.cn> Co-authored-by: Jiaan Geng <beliefer@163.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 7dd2dd5) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
beliefer
commented
May 15, 2019
ContributorAuthor
@HyukjinKwon@srowen Thanks all your help! @gaborgsomogyi@HeartSaVioR Thanks all your review. |
rluta pushed a commit
to rluta/spark
that referenced
this pull request
Sep 17, 2019
…ation`. ## What changes were proposed in this pull request? `StructuredSessionization` comment contains duplicate 'add', I think it should be changed. ## How was this patch tested? Exists UT. Closesapache#24589 from beliefer/remove-duplicate-add-in-comment. Lead-authored-by: gengjiaan <gengjiaan@360.cn> Co-authored-by: Jiaan Geng <beliefer@163.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 7dd2dd5) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
kai-chi pushed a commit
to kai-chi/spark
that referenced
this pull request
Sep 26, 2019
…ation`. ## What changes were proposed in this pull request? `StructuredSessionization` comment contains duplicate 'add', I think it should be changed. ## How was this patch tested? Exists UT. Closesapache#24589 from beliefer/remove-duplicate-add-in-comment. Lead-authored-by: gengjiaan <gengjiaan@360.cn> Co-authored-by: Jiaan Geng <beliefer@163.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 7dd2dd5) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
StructuredSessionizationcomment contains duplicate 'add', I think it should be changed.How was this patch tested?
Exists UT.