Uh oh!
There was an error while loading. Please reload this page.
[SPARK-27713][SQL] Move org.apache.spark.sql.execution.* in catalyst to core - #24607
Closed
xy-xin wants to merge 1 commit into
Closed
[SPARK-27713][SQL] Move org.apache.spark.sql.execution.* in catalyst to core#24607xy-xin wants to merge 1 commit into
xy-xin wants to merge 1 commit into
Conversation
xy-xin
commented
May 15, 2019
Author
cloud-fan
commented
May 15, 2019
Contributor
ok to test |
cloud-fan
commented
May 15, 2019
Contributor
makes sense to me |
HyukjinKwon
commented
May 15, 2019
Member
Yup, makes sense to me too |
kiszk
commented
May 15, 2019
Member
Looks good |
JoshRosen
commented
May 15, 2019
Contributor
👍 from me, especially since these classes are low-level and internal to Spark (so I think there's no risk of breaking third-party packages). |
SparkQA
commented
May 15, 2019
Test build #105396 has finished for PR 24607 at commit
|
viirya
commented
May 15, 2019
Member
Makes sense. The related test suite |
cloud-fan
commented
May 15, 2019
Contributor
thanks, merging to master! |
xy-xin
commented
May 15, 2019
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
RecordBinaryComparator,UnsafeExternalRowSorterandUnsafeKeyValueSorternow locates in catalyst, which should be moved to core, as they're used only in physical plan.How was this patch tested?
exist tests.