[SPARK-28002][SQL][FOLLOWUP] Fix duplicate CTE error message and add more test cases

[peter-toth]

What changes were proposed in this pull request?

This PR adds some more WITH test cases as a follow-up to #24842

How was this patch tested?

Add new UTs.

[HyukjinKwon]

ok to test

[HyukjinKwon]

add to whitelist

[peter-toth]

cc. @gatorsmile, @dongjoon-hyun

[SparkQA]

Test build #106829 has finished for PR 24949 at commit efc96bb.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[dongjoon-hyun]

According to @gatorsmile 's comment, could you add a t(x, x) test case, too?

Duplicate names within a single CTE definition are not allowed.

[gatorsmile]

We need to capture the duplicate names earlier and issue a better error message

[peter-toth]

Hmm, I added the t(x, x) case, but it is allowed, and I think it is right to be allowed.
I thought @gatorsmile referred to the

WITH
t(x) AS (SELECT 1),
t(x) AS (SELECT 2)
SELECT * FROM t;

case, which is not.

@gatorsmile we capture the duplicate CTE name during parsing, I fixed the error message though.

If I got something wrong please let me know.

[peter-toth]

@gatorsmile, @dongjoon-hyun do you think the PR is ok now?

[SparkQA]

Test build #106845 has finished for PR 24949 at commit 815bb27.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #106871 has finished for PR 24949 at commit 8fbae02.

• This patch fails due to an unknown error code, -9.
• This patch merges cleanly.
• This patch adds no public classes.

[peter-toth]

retest this please

[SparkQA]

Test build #106875 has finished for PR 24949 at commit 8fbae02.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[peter-toth]

@gatorsmile, @dongjoon-hyun is there anything I can add to this PR?

[dongjoon-hyun]

Do you think we can have a more meaningful message?

[peter-toth]

I think this standard message comes from antlr when the query doesn't fit to the .g4 definition. I'm not sure if it can be fixed.

[SparkQA]

Test build #107277 has finished for PR 24949 at commit 0c39fb2.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[dongjoon-hyun]

+1, LGTM. Merged to master.
Thank you, @peter-toth , @gatorsmile , @HyukjinKwon .

[peter-toth]

Thanks for the review @dongjoon-hyun, @HyukjinKwon, @gatorsmile!