Uh oh!
There was an error while loading. Please reload this page.
[SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals - #25018
[SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals#25018wangyum wants to merge 8 commits into
Conversation
SparkQA
commented
Jun 30, 2019
Test build #107050 has finished for PR 25018 at commit
|
gatorsmile
commented
Jul 19, 2019
Could you port the test cases from the original PR #23276 |
SparkQA
commented
Jul 20, 2019
Test build #107932 has finished for PR 25018 at commit
|
HyukjinKwon
commented
Sep 18, 2019
@wangyum, if this is simply porting the fix, let's go ahead. can you resolve conflicts? |
# Conflicts: # sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala # sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
wangyum
commented
Sep 18, 2019
@HyukjinKwon Done |
SparkQA
commented
Sep 18, 2019
Test build #110920 has finished for PR 25018 at commit
|
HyukjinKwon
commented
Oct 10, 2019
retest this please |
HyukjinKwon
left a comment
There was a problem hiding this comment.
@wangyum, I think you can merge if you're pretty confident on this.
wangyum
commented
Oct 10, 2019
Thank you @HyukjinKwon I added another test case. |
SparkQA
commented
Oct 11, 2019
Test build #111931 has finished for PR 25018 at commit
|
wangyum
commented
Oct 12, 2019
retest this please |
SparkQA
commented
Oct 12, 2019
Test build #111940 has finished for PR 25018 at commit
|
SparkQA
commented
Oct 13, 2019
Test build #111990 has finished for PR 25018 at commit
|
wangyum
commented
Oct 13, 2019
Merged to master. |
What changes were proposed in this pull request?
This pr port HIVE-15297 to fix spark-sql should not split semicolon within quoted string literals.
How was this patch tested?
unit tests and manual tests:
