Uh oh!
There was an error while loading. Please reload this page.
[MINOR][SQL] Clean up ObjectProducerExec operators - #25065
Conversation
SparkQA
commented
Jul 7, 2019
Test build #107306 has finished for PR 25065 at commit
|
Hi, @jaceklaskowski . Could you make a JIRA issue for this? Thanks. |
srowen
commented
Jul 8, 2019
A JIRA won't hurt but this looks like just a code cleanup; there should be no functional change. |
jaceklaskowski
commented
Jul 10, 2019
@dongjoon-hyun When I created the PR I thought to make a JIRA issue, but it's just a simple refactoring (code cleanup) so I don't think it begs for one. |
dongjoon-hyun
commented
Jul 10, 2019
Okay. Then, I leave this PR to the other reviews. |
I'm fine either way. I also prefer to have a JIRA in general for trackability, for instance, backporting stuff. I think this PR is boundary between no JIRA and JIRA :-). As an example, there was a recent and rather similar change at #25052 with JIRA so it's not a bad idea to have a JIRA. |
srowen
commented
Jul 11, 2019
Merged to master. I think it's fine. |
## What changes were proposed in this pull request? Cleaned up (removed) code duplication in `ObjectProducerExec` operators so they use the trait's methods. ## How was this patch tested? Local build. Waiting for Jenkins. Closesapache#25065 from jaceklaskowski/ObjectProducerExec-operators-cleanup. Authored-by: Jacek Laskowski <jacek@japila.pl> Signed-off-by: Sean Owen <sean.owen@databricks.com>
What changes were proposed in this pull request?
Cleaned up (removed) code duplication in
ObjectProducerExecoperators so they use the trait's methods.How was this patch tested?
Local build. Waiting for Jenkins.