Uh oh!
There was an error while loading. Please reload this page.
[SPARK-28331][SQL] Catalogs.load() should be able to load built-in catalogs - #25094
Closed
gengliangwang wants to merge 1 commit into
Closed
[SPARK-28331][SQL] Catalogs.load() should be able to load built-in catalogs#25094gengliangwang wants to merge 1 commit into
gengliangwang wants to merge 1 commit into
Conversation
gengliangwang
commented
Jul 10, 2019
MemberAuthor
SparkQA
commented
Jul 10, 2019
Test build #107454 has finished for PR 25094 at commit
|
| public static CatalogPlugin load(String name, SQLConf conf) | ||
| throws CatalogNotFoundException, SparkException { | ||
| String pluginClassName = conf.getConfString("spark.sql.catalog." + name, null); | ||
| if (pluginClassName == null) { |
There was a problem hiding this comment.
Could you add a regression test case for this?
rdblue
commented
Jul 10, 2019
Contributor
Let's wait on this. The problem it fixes hasn't been committed yet. |
brkyvz
commented
Jul 17, 2019
Contributor
cc @gengliangwang Do you have time to update this? |
rdblue
commented
Jul 17, 2019
Contributor
Also, do we need both this and #25104? |
brkyvz
commented
Aug 5, 2019
Contributor
retest this please |
SparkQA
commented
Aug 5, 2019
Test build #108677 has finished for PR 25094 at commit
|
brkyvz
commented
Aug 7, 2019
Contributor
LGTM. Merging this to master. Tests in @cloud-fan's refactoring should catch these. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
Catalogs.load, thepluginClassNamein the following codeis always null for built-in catalogs, e.g there is a SQLConf entry
spark.sql.catalog.session.This is because of #18852: SQLConf.conf.getConfString(key, null) always returns null.
How was this patch tested?
Apply code changes of #24768 and tried loading session catalog.