Uh oh!
There was an error while loading. Please reload this page.
[SPARK-26978][SQL][FOLLOWUP] Initialize date-time constants by foldable expressions - #25116
Closed
MaxGekk wants to merge 1 commit into
Closed
[SPARK-26978][SQL][FOLLOWUP] Initialize date-time constants by foldable expressions#25116MaxGekk wants to merge 1 commit into
MaxGekk wants to merge 1 commit into
Conversation
MaxGekk
commented
Jul 11, 2019
MemberAuthor
@srowen@hvanhovell Please, review the PR. |
srowen
approved these changes
Jul 11, 2019
dongjoon-hyun
approved these changes
Jul 11, 2019
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM, too.
This is the same logic from delta/DateTimeUtils.scala.
SparkQA
commented
Jul 11, 2019
Test build #107537 has finished for PR 25116 at commit
|
hvanhovell
commented
Jul 11, 2019
Contributor
Merging to master. |
vinodkc pushed a commit
to vinodkc/spark
that referenced
this pull request
Jul 18, 2019
…le expressions ## What changes were proposed in this pull request? Reverted initialization of date-time constants in `DateTimeUtils` introduced by apache#23878. As a comment in [Delta repo](https://github.com/delta-io/delta) states, the compiler can do additional optimizations if values can be calculated at compile time: https://github.com/delta-io/delta/blob/master/src/main/scala/org/apache/spark/sql/delta/util/DateTimeUtils.scala#L63-L75 ## How was this patch tested? This was tested by existing test suites. Closesapache#25116 from MaxGekk/datetime-consts-init. Authored-by: Maxim Gekk <maxim.gekk@databricks.com> Signed-off-by: herman <herman@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reverted initialization of date-time constants in
DateTimeUtilsintroduced by #23878. As a comment in Delta repo states, the compiler can do additional optimizations if values can be calculated at compile time: https://github.com/delta-io/delta/blob/master/src/main/scala/org/apache/spark/sql/delta/util/DateTimeUtils.scala#L63-L75How was this patch tested?
This was tested by existing test suites.