Skip to content

[SPARK-28201][SQL][TEST][FOLLOWUP] Fix Integration test suite according to the new exception message - #25165

Closed
dongjoon-hyun wants to merge 2 commits into
apache:masterfrom
dongjoon-hyun:SPARK-28201
Closed

[SPARK-28201][SQL][TEST][FOLLOWUP] Fix Integration test suite according to the new exception message#25165
dongjoon-hyun wants to merge 2 commits into
apache:masterfrom
dongjoon-hyun:SPARK-28201

Conversation

@dongjoon-hyun

@dongjoon-hyundongjoon-hyun commented Jul 15, 2019•
edited
Loading

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

#25010 breaks the integration test suite due to the changing the user-facing exception like the following. This PR fixes the integration test suite.

- require(
- decimalVal.precision <= precision,
-s"Decimal precision ${decimalVal.precision} exceeds max precision $precision")
+if (decimalVal.precision > precision) {
+thrownewArithmeticException(
+s"Decimal precision ${decimalVal.precision} exceeds max precision $precision")
+ }

How was this patch tested?

Manual test.

$ build/mvn install -DskipTests
$ build/mvn -Pdocker-integration-tests -pl :spark-docker-integration-tests_2.12 test

@dongjoon-hyundongjoon-hyun mentioned this pull request Jul 15, 2019
Closed
@dongjoon-hyun

dongjoon-hyun commented Jul 15, 2019

Copy link
Copy Markdown
MemberAuthor

cc @mgaido91 and @cloud-fan

@dongjoon-hyun

dongjoon-hyun commented Jul 15, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

For reviewers, I'm using deepdiver/docker-oracle-xe-11g for master and branch-2.4, but it's an unofficial image. So, I didn't include it in the PR description.

mgaido91
mgaido91 reviewed Jul 15, 2019
View reviewed changes

@mgaido91mgaido91 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a personal consideration

Comment thread...cker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
}
assert(e.getMessage.contains(
"requirement failed: Decimal precision 39 exceeds max precision 38"))
assert(e.getMessage.contains("Decimal precision 39 exceeds max precision 38"))

@mgaido91mgaido91Jul 15, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a very nit, I'd rather check the exception type, which I think is more important than the exact message. Now we should be coherent in the whole codebase and always throw an ArithmeticException, while previously we were sometimes throwing RuntimeException or others for the same case.

@dongjoon-hyundongjoon-hyunJul 15, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for review, @mgaido91 .

Sure, of course, we can check the underlying exception type by e.getCause from SparkException additionally. I'll add that.

BTW, message checking is a more fine-grained verification. As you know, ArithmeticException and ParseException are not specific. For example, ArithmeticException can be caused by divide by zero. We should check the error message always.

@SparkQA

SparkQA commented Jul 15, 2019

Copy link
Copy Markdown

Test build #107698 has finished for PR 25165 at commit 0de5843.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

SparkQA commented Jul 15, 2019

Copy link
Copy Markdown

Test build #107702 has finished for PR 25165 at commit a822c71.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyundongjoon-hyun changed the title [SPARK-28201][SQL][TEST][FOLLOWUP] Update Integration test suite according to the new exception message[SPARK-28201][SQL][TEST][FOLLOWUP] Fix Integration test suite according to the new exception messageJul 15, 2019
@cloud-fan

cloud-fan commented Jul 16, 2019

Copy link
Copy Markdown
Contributor

thanks, merging to master!

@dongjoon-hyun

dongjoon-hyun commented Jul 16, 2019

Copy link
Copy Markdown
MemberAuthor

Thank you, @cloud-fan and @mgaido91 !

@dongjoon-hyun
dongjoon-hyun deleted the SPARK-28201 branch July 16, 2019 15:41
vinodkc pushed a commit to vinodkc/spark that referenced this pull request Jul 18, 2019
@dongjoon-hyun@vinodkc
[SPARK-28201][SQL][TEST][FOLLOWUP] Fix Integration test suite accordi…
da8c4e0
…ng to the new exception message
## What changes were proposed in this pull request?
apache#25010 breaks the integration test suite due to the changing the user-facing exception like the following. This PR fixes the integration test suite.
```scala
- require(
- decimalVal.precision <= precision,
- s"Decimal precision ${decimalVal.precision} exceeds max precision $precision")
+ if (decimalVal.precision > precision) {
+ throw new ArithmeticException(
+ s"Decimal precision ${decimalVal.precision} exceeds max precision $precision")
+ }
```
## How was this patch tested?
Manual test.
```
$ build/mvn install -DskipTests
$ build/mvn -Pdocker-integration-tests -pl :spark-docker-integration-tests_2.12 test
```
Closesapache#25165 from dongjoon-hyun/SPARK-28201.
Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mgaido91mgaido91mgaido91 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

SQLTESTS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dongjoon-hyun@SparkQA@cloud-fan@mgaido91