[SPARK-3412][SQL]add missing row api

[adrian-wang]

@chenghao-intel assigned this to me, check PR #2284 for previous discussion

[SparkQA]

QA tests have started for PR 2529 at commit 1614493.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 2529 at commit 1614493.

• This patch passes unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20776/

[marmbrus]

I don't think there is any reason to have this function. The update call works independent of type already.

[marmbrus]

Thanks for working on this! A few minor comments.

[SparkQA]

QA tests have started for PR 2529 at commit 4c18c29.

• This patch merges cleanly.

[SparkQA]

Tests timed out after a configured wait of 120m.

[AmplabJenkins]

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20934/

[adrian-wang]

retest this please.

[AmplabJenkins]

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21021/

[SparkQA]

QA tests have started for PR 2529 at commit 4c18c29.

• This patch merges cleanly.

[adrian-wang]

retest this please.

[AmplabJenkins]

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21023/

[SparkQA]

QA tests have started for PR 2529 at commit 4c18c29.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 2529 at commit 4c18c29.

• This patch passes unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

QA tests have finished for PR 2529 at commit 4c18c29.

• This patch passes unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[marmbrus]

You don't want the first .asInstanceOfhere as it can cause errors.

scala>newSpecificMutableRow(IntegerType::Nil).getAs[Int](0)
java.lang.ClassCastException: org.apache.spark.sql.catalyst.expressions.MutableInt cannot be cast to org.apache.spark.sql.catalyst.expressions.MutableAny

Since all MutableValue classes have a .value method I think you can just leave it out.

[marmbrus]

Also, looks like this file has always been named wrong. Would you mind fixing that (to SpecificMutableRow.scala) while you are at it?

[marmbrus]

Only one small change then this LGTM.

[SparkQA]

QA tests have started for PR 2529 at commit 7b7e6e3.

• This patch merges cleanly.

[AmplabJenkins]

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21448/Test FAILed.

[adrian-wang]

retest this please.

[SparkQA]

QA tests have started for PR 2529 at commit 7b7e6e3.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 2529 at commit 7b7e6e3.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21449/Test PASSed.

[SparkQA]

QA tests have finished for PR 2529 at commit 7b7e6e3.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21451/Test FAILed.

[adrian-wang]

retest this please.

[SparkQA]

QA tests have started for PR 2529 at commit 7b7e6e3.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 2529 at commit 7b7e6e3.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21453/Test PASSed.

[marmbrus]

Can't this just be override def getAs[T](i: Int): T = values(i).boxed.asInstanceOf[T]?

[marmbrus]

And I'm sorry for going back again. I should have said boxed instead of value in my previous comment.

[adrian-wang]

Sorry for miss that, I didn't notice .boxed method there...

[SparkQA]

QA tests have started for PR 2529 at commit c6594b2.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 2529 at commit c6594b2.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21510/Test PASSed.

[marmbrus]

Thanks! Merged to master.