Uh oh!
There was an error while loading. Please reload this page.
[SPARK-28578][INFRA] Improve Github pull request template - #25310
[SPARK-28578][INFRA] Improve Github pull request template#25310HyukjinKwon wants to merge 5 commits into
Conversation
HyukjinKwon
commented
Jul 31, 2019
cc @apache/spark-committers |
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
tgravescs
commented
Jul 31, 2019
so I think this brings up a good question as to what we want in the jira and what we want in the PR. Many times they have the same information. Do we want it to be copied to both places, referenced, etc.? |
srowen
commented
Jul 31, 2019
This is covered in the contributing guide, though that's a big doc. It could be worth a note here that contributors should pay attention to the relationship between JIRAs and PRs as described there. Though I suppose they should really read it all. |
HyukjinKwon
commented
Aug 1, 2019
I think basically JIRA describes what issue and PR describes how it is fixed. Each focuses on each's purpose but other information can be duplicated for better and faster reviews. I think it's case-by-case. |
HyukjinKwon
commented
Aug 1, 2019
Let me cc some more active contributors who didn't put input here for better visibility and to collect more feedback. cc @viirya@mgaido91@MaxGekk@HeartSaVioR@gaborgsomogyi@dilipbiswal |
viirya
commented
Aug 1, 2019
via email
Thanks.
Don't have stable Internet connection right now.
May look into it and provide feedback tomorrow or later. …On Wed, Jul 31, 2019, 20:50 Hyukjin Kwon ***@***.***> wrote:
Let me cc some more active contributors who didn't put input here for
better visibility and to collect more feedback. cc @viirya
<https://github.com/viirya> @mgaido91 <https://github.com/mgaido91>
@MaxGekk <https://github.com/MaxGekk> @HeartSaVioR
<https://github.com/HeartSaVioR> @gaborgsomogyi
<https://github.com/gaborgsomogyi> @dilipbiswal
<https://github.com/dilipbiswal>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25310?email_source=notifications&email_token=AAAQZ5466PS7A66XOWZYGULQCJMO3A5CNFSM4IIDLKYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3JG4WQ#issuecomment-517107290>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAQZ5YUUVAOWXLWG5F3PJLQCJMO3ANCNFSM4IIDLKYA>
.
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
mgaido91
left a comment
There was a problem hiding this comment.
thanks for pinging me @HyukjinKwon
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
abe9701 to
3b675ffCompare
BryanCutler
left a comment
There was a problem hiding this comment.
Looks great, thanks @HyukjinKwon ! I just had some minor grammatical suggestions.
HyukjinKwon
commented
Aug 9, 2019
I was stuck in some works. Let me update it tomorrow in KST. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
HyukjinKwon
commented
Aug 13, 2019
I address the comments. Should be ready for a look. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gaborgsomogyi
commented
Aug 13, 2019
retest this please |
SparkQA
commented
Aug 13, 2019
Test build #109031 has finished for PR 25310 at commit
|
HyukjinKwon
commented
Aug 15, 2019
Let me merge this one in few days if there are no more comments. |
HyukjinKwon
commented
Aug 16, 2019
Merged to master. |
HyukjinKwon
commented
Aug 16, 2019
Let's see how it goes. thanks guys! |
What changes were proposed in this pull request?
This PR proposes to improve the Github template for better and faster review iterations and better interactions between PR authors and reviewers.
As suggested in the the dev mailing list, this PR referred Kubernates' PR template.
Therefore, those fields are newly added:
and some comments were added.
Why are the changes needed?
Currently, many PR descriptions are poorly formatted, which causes some overheads between PR authors and reviewers.
There are multiple problems by those poorly formatted PR descriptions:
This PR targets to alleviate the problems and situation.
Does this PR introduce any user-facing change?
Yes, it changes the PR templates when PRs are open. This PR uses the template this PR proposes.
How was this patch tested?
Manually tested via Github preview feature.