Skip to content

SPARK-3638 | Forced a compatible version of http client in kinesis-asl profile - #2535

Closed
aniketbhatnagar wants to merge 6 commits into
apache:masterfrom
aniketbhatnagar:Kinesis-HttpClient-Dep-Fix
Closed

SPARK-3638 | Forced a compatible version of http client in kinesis-asl profile#2535
aniketbhatnagar wants to merge 6 commits into
apache:masterfrom
aniketbhatnagar:Kinesis-HttpClient-Dep-Fix

Conversation

@aniketbhatnagar

Copy link
Copy Markdown
Contributor

This patch forces use of commons http client 4.2 in Kinesis-asl profile so that the AWS SDK does not run into dependency conflicts

…l profile
This patch forces commons httpclient 4.2 dependency over an older
httpclient dependency in kinesis-asl-profile so the AWS SDK works
@AmplabJenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@JoshRosen

Copy link
Copy Markdown
Contributor

Jenkins, this is ok to test.

@SparkQA

Copy link
Copy Markdown

QA tests have started for PR 2535 at commit 9cd6103.

  • This patch merges cleanly.

Comment threadpom.xml Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind using version 4.2.6 instead of 4.2? According to http://ispras.linuxbase.org/index.php/Java_API_Compliance_Checker, there are no binary incompatibilities between 4.2 and 4.2.6, so we should prefer to use the newer version.

@SparkQA

Copy link
Copy Markdown

QA tests have finished for PR 2535 at commit 9cd6103.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20884/

…l profile
This patch forces commons httpclient 4.2 dependency over an older
httpclient dependency in kinesis-asl-profile so the AWS SDK works
… Kinesis-HttpClient-Dep-Fix
Conflicts:
pom.xml
@SparkQA

Copy link
Copy Markdown

QA tests have started for PR 2535 at commit 70cc75b.

  • This patch merges cleanly.

…l profile
This patch forces commons httpclient 4.2 dependency over an older
httpclient dependency in kinesis-asl-profile so the AWS SDK works
@aniketbhatnagar

Copy link
Copy Markdown
ContributorAuthor

Thanks @JoshRosen, I have bumped up the version to 4.2.6.

@SparkQA

Copy link
Copy Markdown

QA tests have started for PR 2535 at commit aa2079f.

  • This patch merges cleanly.

@SparkQA

Copy link
Copy Markdown

QA tests have finished for PR 2535 at commit 70cc75b.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20892/

@SparkQA

Copy link
Copy Markdown

QA tests have finished for PR 2535 at commit aa2079f.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20893/

@JoshRosen

Copy link
Copy Markdown
Contributor

This looks good to me. Thanks!

asfgit pushed a commit that referenced this pull request Oct 2, 2014
…l profile
This patch forces use of commons http client 4.2 in Kinesis-asl profile so that the AWS SDK does not run into dependency conflicts
Author: aniketbhatnagar <aniket.bhatnagar@gmail.com>
Closes#2535 from aniketbhatnagar/Kinesis-HttpClient-Dep-Fix and squashes the following commits:
aa2079f [aniketbhatnagar] Merge branch 'Kinesis-HttpClient-Dep-Fix' of https://github.com/aniketbhatnagar/spark into Kinesis-HttpClient-Dep-Fix
73f55f6 [aniketbhatnagar] SPARK-3638 | Forced a compatible version of http client in kinesis-asl profile
70cc75b [aniketbhatnagar] deleted merge files
725dbc9 [aniketbhatnagar] Merge remote-tracking branch 'origin/Kinesis-HttpClient-Dep-Fix' into Kinesis-HttpClient-Dep-Fix
4ed61d8 [aniketbhatnagar] SPARK-3638 | Forced a compatible version of http client in kinesis-asl profile
9cd6103 [aniketbhatnagar] SPARK-3638 | Forced a compatible version of http client in kinesis-asl profile
(cherry picked from commit 93861a5)
Signed-off-by: Josh Rosen <joshrosen@apache.org>
@asfgitasfgit closed this in 93861a5Oct 2, 2014
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@aniketbhatnagar@AmplabJenkins@JoshRosen@SparkQA