Skip to content

[SPARK-28178][SQL][followup] DataSourceV2: DataFrameWriter.insertInfo - #25353

Closed
jzhuge wants to merge 1 commit into
apache:masterfrom
jzhuge:SPARK-28178-bypos
Closed

[SPARK-28178][SQL][followup] DataSourceV2: DataFrameWriter.insertInfo#25353
jzhuge wants to merge 1 commit into
apache:masterfrom
jzhuge:SPARK-28178-bypos

Conversation

@jzhuge

@jzhugejzhuge commented Aug 4, 2019

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

  • DataFrameWriter.insertInto should match column names by position.
  • Clean up test cases.

How was this patch tested?

New tests:

  • insertInto: append by position
  • insertInto: overwrite partitioned table in static mode by position
  • insertInto: overwrite partitioned table in dynamic mode by position

Match column names by position.
Clean up test cases.
@SparkQA

Copy link
Copy Markdown

Test build #108629 has finished for PR 25353 at commit 7313f1e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyundongjoon-hyun changed the title [SPARK-28178][SQL][HOTFIX] DataSourceV2: DataFrameWriter.insertInfo[SPARK-28178][SQL] DataSourceV2: DataFrameWriter.insertInfoAug 5, 2019
@dongjoon-hyun

Copy link
Copy Markdown
Member

Hi, @jzhuge . HOTFIX is used when the branch is broken and all the PR builders are failed due to that.

@cloud-fancloud-fan changed the title [SPARK-28178][SQL] DataSourceV2: DataFrameWriter.insertInfo[SPARK-28178][SQL][followup] DataSourceV2: DataFrameWriter.insertInfoAug 5, 2019
@cloud-fan

Copy link
Copy Markdown
Contributor

thanks, merging to master!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jzhuge@SparkQA@dongjoon-hyun@cloud-fan