Uh oh!
There was an error while loading. Please reload this page.
[SPARK-28616][INFRA] Improve merge-spark-pr script to warn WIP PRs and strip trailing dots - #25356
[SPARK-28616][INFRA] Improve merge-spark-pr script to warn WIP PRs and strip trailing dots#25356dongjoon-hyun wants to merge 1 commit into
Conversation
…d strip trailing dots
SparkQA
commented
Aug 5, 2019
Test build #108637 has finished for PR 25356 at commit
|
HyukjinKwon
commented
Aug 5, 2019
retest this please |
dongjoon-hyun
commented
Aug 5, 2019
All test passed and the CRAN check failed because they seems to start to enforce R 3.4 and the above. I'll merge this PR since this is not related to the Spark code. |
dongjoon-hyun
commented
Aug 5, 2019
Thank you always for review and approval, @HyukjinKwon ! |
dongjoon-hyun
commented
Aug 5, 2019
Oops. I didn't read your |
HyukjinKwon
commented
Aug 5, 2019
I think that's fine. |
AmplabJenkins
commented
Aug 5, 2019
Test FAILed. |
dongjoon-hyun
commented
Aug 5, 2019
I'll file a JIRA for CRAN failure since we need to upgrade R in Jenkins. |
HyukjinKwon
commented
Aug 5, 2019
Thanks. This error seems to be newer one. cc @viirya FYI. |
dongjoon-hyun
commented
Aug 5, 2019
Ya. I'm checking the other commits and found that #24560 passed 4 hours ago without this problem. Maybe, it might be a transient issue. I'll keep monitoring~ |
viirya
commented
Aug 6, 2019
Looks different to previous CRAN error. Was it happened again? |
HyukjinKwon
commented
Aug 6, 2019
Yes, seems so - #25363 (comment) |
HyukjinKwon
commented
Aug 6, 2019
looks intermittent though .. |
dongjoon-hyun
commented
Sep 18, 2019
I'll backport this to |
…d strip trailing dots ## What changes were proposed in this pull request? This PR aims to improve the `merge-spark-pr` script in the following two ways. 1. `[WIP]` is useful when we show that a PR is not ready for merge. Apache Spark allows merging `WIP` PRs. However, sometime, we accidentally forgot to clean up the title for the completed PRs. We had better warn once more during merging stage and get a confirmation from the committers. 2. We have two kinds of PR titles in terms of the ending period. This PR aims to remove the trailing `dot` since the shorter is the better in the commit title. Also, the PR titles without the trailing `dot` is dominant in the Apache Spark commit logs. ``` $ git log --oneline | grep '[.]$' | wc -l 4090 $ git log --oneline | grep '[^.]$' | wc -l 20747 ``` ## How was this patch tested? Manual. ``` $ dev/merge_spark_pr.py git rev-parse --abbrev-ref HEAD Which pull request would you like to merge? (e.g. 34): 25157 The PR title has `[WIP]`: [WIP][SPARK-28396][SQL] Add PathCatalog for data source V2 Continue? (y/n): ``` ``` $ dev/merge_spark_pr.py git rev-parse --abbrev-ref HEAD Which pull request would you like to merge? (e.g. 34): 25304 I've re-written the title as follows to match the standard format: Original: [SPARK-28570][CORE][SHUFFLE] Make UnsafeShuffleWriter use the new API. Modified: [SPARK-28570][CORE][SHUFFLE] Make UnsafeShuffleWriter use the new API Would you like to use the modified title? (y/n): ``` Closes#25356 from dongjoon-hyun/SPARK-28616. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit ae08387) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
What changes were proposed in this pull request?
This PR aims to improve the
merge-spark-prscript in the following two ways.[WIP]is useful when we show that a PR is not ready for merge. Apache Spark allows mergingWIPPRs. However, sometime, we accidentally forgot to clean up the title for the completed PRs. We had better warn once more during merging stage and get a confirmation from the committers.dotsince the shorter is the better in the commit title. Also, the PR titles without the trailingdotis dominant in the Apache Spark commit logs.How was this patch tested?
Manual.