[SPARK-3701][MLLIB] update python linalg api and small fixes by mengxr · Pull Request #2548 · apache/spark

mengxr · 2014-09-26T20:31:17Z

doc updates
simple checks on vector dimensions
use column major for matrices

@davies @jkbradley

SparkQA · 2014-09-26T20:34:32Z

QA tests have started for PR 2548 at commit 131ee3a.

This patch merges cleanly.

SparkQA · 2014-09-26T20:35:38Z

QA tests have finished for PR 2548 at commit 131ee3a.

This patch fails unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-09-26T20:35:39Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20874/

SparkQA · 2014-09-26T21:01:37Z

QA tests have started for PR 2548 at commit ef853f9.

This patch merges cleanly.

jkbradley · 2014-09-26T21:39:05Z

I'm pretty sure "major" is more common than "majored" (I think this typo exists elsewhere in MLlib too.)

jkbradley · 2014-09-26T21:44:56Z

LGTM (other than the one typo)

SparkQA · 2014-09-26T21:59:40Z

QA tests have finished for PR 2548 at commit ef853f9.

This patch fails unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-09-26T21:59:44Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20875/

JoshRosen · 2014-09-26T22:00:35Z

Build failure is my fault, due to merging #2351. I've reverted it and re-triggered your unit tests.

SparkQA · 2014-09-26T22:02:59Z

QA tests have started for PR 2548 at commit ef853f9.

This patch merges cleanly.

SparkQA · 2014-09-26T23:11:02Z

QA tests have finished for PR 2548 at commit ef853f9.

This patch passes unit tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2014-09-27T00:24:27Z

QA tests have started for PR 2548 at commit 067ef71.

This patch merges cleanly.

SparkQA · 2014-09-27T01:25:46Z

QA tests have finished for PR 2548 at commit 067ef71.

This patch fails unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-09-27T01:25:50Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20890/

JoshRosen · 2014-09-27T02:11:14Z

This new failure looks like it might be legitimate.

SparkQA · 2014-09-29T21:09:43Z

QA tests have started for PR 2548 at commit fefce00.

This patch merges cleanly.

SparkQA · 2014-09-29T21:10:50Z

QA tests have finished for PR 2548 at commit fefce00.

This patch fails unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-09-29T21:10:51Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20998/

SparkQA · 2014-09-29T21:24:41Z

QA tests have started for PR 2548 at commit 75f2fcc.

This patch merges cleanly.

SparkQA · 2014-09-29T22:22:59Z

QA tests have finished for PR 2548 at commit 75f2fcc.

This patch fails unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-09-29T22:23:02Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20999/

SparkQA · 2014-09-29T23:09:33Z

QA tests have started for PR 2548 at commit 116b5db.

This patch merges cleanly.

SparkQA · 2014-09-30T00:01:18Z

QA tests have finished for PR 2548 at commit 116b5db.

This patch fails unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-09-30T00:01:21Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21005/

mengxr · 2014-09-30T00:09:38Z

test this please

SparkQA · 2014-09-30T00:14:46Z

QA tests have started for PR 2548 at commit 116b5db.

This patch merges cleanly.

SparkQA · 2014-09-30T01:23:59Z

QA tests have finished for PR 2548 at commit 116b5db.

This patch passes unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-09-30T01:24:02Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21009/

jkbradley · 2014-09-30T20:11:37Z

typo "dimentaional"

jkbradley · 2014-09-30T20:17:13Z

@mengxr LGTM, except for the typo and question above

SparkQA · 2014-09-30T20:59:45Z

QA tests have started for PR 2548 at commit 6dce2df.

This patch merges cleanly.

SparkQA · 2014-09-30T21:54:29Z

QA tests have finished for PR 2548 at commit 6dce2df.

This patch fails unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-09-30T21:54:33Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21064/

mengxr · 2014-09-30T22:36:06Z

test this please

SparkQA · 2014-09-30T22:39:28Z

QA tests have started for PR 2548 at commit 6dce2df.

This patch merges cleanly.

SparkQA · 2014-09-30T23:47:52Z

QA tests have finished for PR 2548 at commit 6dce2df.

This patch passes unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-09-30T23:47:55Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21069/

mengxr · 2014-10-01T00:10:57Z

Merged into master. Thanks @jkbradley for review!

update python linalg api and small fixes
ef853f9

mengxr force-pushed the mllib-py-clean branch from 131ee3a to ef853f9Compare September 26, 2014 20:52

jkbradley reviewed Sep 26, 2014
View reviewed changes

majored -> major
067ef71

better check of vector size with more tests
fefce00

fix python style
75f2fcc

use np.dot instead of array.dot
116b5db

jkbradley reviewed Sep 30, 2014
View reviewed changes

address comments
6dce2df

asfgit closed this in d75496bOct 1, 2014

Uh oh!

Conversation

mengxr commented Sep 26, 2014

Uh oh!

SparkQA commented Sep 26, 2014

Uh oh!

SparkQA commented Sep 26, 2014

Uh oh!

AmplabJenkins commented Sep 26, 2014

Uh oh!

SparkQA commented Sep 26, 2014

Uh oh!

jkbradleySep 26, 2014

Choose a reason for hiding this comment

Uh oh!

jkbradley commented Sep 26, 2014

Uh oh!

SparkQA commented Sep 26, 2014

Uh oh!

AmplabJenkins commented Sep 26, 2014

Uh oh!

JoshRosen commented Sep 26, 2014

Uh oh!

SparkQA commented Sep 26, 2014

Uh oh!

SparkQA commented Sep 26, 2014

Uh oh!

SparkQA commented Sep 27, 2014

Uh oh!

SparkQA commented Sep 27, 2014

Uh oh!

AmplabJenkins commented Sep 27, 2014

Uh oh!

JoshRosen commented Sep 27, 2014

Uh oh!

SparkQA commented Sep 29, 2014

Uh oh!

SparkQA commented Sep 29, 2014

Uh oh!

AmplabJenkins commented Sep 29, 2014

Uh oh!

SparkQA commented Sep 29, 2014

Uh oh!

SparkQA commented Sep 29, 2014

Uh oh!

AmplabJenkins commented Sep 29, 2014

Uh oh!

SparkQA commented Sep 29, 2014

Uh oh!

SparkQA commented Sep 30, 2014

Uh oh!

AmplabJenkins commented Sep 30, 2014

Uh oh!

mengxr commented Sep 30, 2014

Uh oh!

SparkQA commented Sep 30, 2014

Uh oh!

SparkQA commented Sep 30, 2014

Uh oh!

AmplabJenkins commented Sep 30, 2014

Uh oh!

jkbradleySep 30, 2014

Choose a reason for hiding this comment

Uh oh!

mengxrSep 30, 2014

Choose a reason for hiding this comment

Uh oh!

jkbradley commented Sep 30, 2014

Uh oh!

SparkQA commented Sep 30, 2014

Uh oh!

SparkQA commented Sep 30, 2014

Uh oh!

AmplabJenkins commented Sep 30, 2014

Uh oh!

mengxr commented Sep 30, 2014

Uh oh!

SparkQA commented Sep 30, 2014

Uh oh!

SparkQA commented Sep 30, 2014