Uh oh!
There was an error while loading. Please reload this page.
[SPARK-28701][INFRA][FOLLOWUP] Fix the key error when looking in os.environ - #25585
[SPARK-28701][INFRA][FOLLOWUP] Fix the key error when looking in os.environ#25585shaneknapp wants to merge 1 commit into
Conversation
shaneknapp
commented
Aug 26, 2019
it behooves us, when checking for env vars in non-prb builds, to always check for the key before referencing it in an |
shaneknapp
commented
Aug 26, 2019
once we get to the |
shaneknapp
commented
Aug 26, 2019
thanks @dongjoon-hyun |
SparkQA
commented
Aug 26, 2019
Test build #109747 has finished for PR 25585 at commit
|
shaneknapp
commented
Aug 26, 2019
this has to be unrelated... should i test again or just go ahead and merge? |
srowen
commented
Aug 26, 2019
It clearly fixes the issue that was failing before, right? you can see the desired output in the logs that even starts the tests? then I'd merge it. That can't be related. |
shaneknapp
commented
Aug 26, 2019
alrighty! things looking good. the builds i broke (spark-master-test-sbt-*) are good, and i spot-checked one (https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-3.2/324/) and the spark unit tests just started successfully: |
What changes were proposed in this pull request?
i broke run-tests.py for non-PRB builds in this PR:
#25423
Why are the changes needed?
to fix what i broke
Does this PR introduce any user-facing change?
no
How was this patch tested?
the build system will test this