Uh oh!
There was an error while loading. Please reload this page.
[SPARK-23243][CORE][FOLLOWUP] Remove todo added by SPARK-23207 - #25755
Closed
LinhongLiu wants to merge 1 commit into
Closed
[SPARK-23243][CORE][FOLLOWUP] Remove todo added by SPARK-23207#25755LinhongLiu wants to merge 1 commit into
LinhongLiu wants to merge 1 commit into
Conversation
LinhongLiu
commented
Sep 11, 2019
ContributorAuthor
srowen
approved these changes
Sep 11, 2019
cloud-fan
commented
Sep 11, 2019
Contributor
thanks, merging to master! Since it only removes 2 lines of comment, I skip the jenkins this time. |
SparkQA
commented
Sep 11, 2019
Test build #4861 has finished for PR 25755 at commit
|
PavithraRamachandran pushed a commit
to PavithraRamachandran/spark
that referenced
this pull request
Sep 15, 2019
### What changes were proposed in this pull request? PR apache#22112 fixed the todo added by PR apache#20393(SPARK-23207). We can remove it now. ### Why are the changes needed? In order not to confuse developers. ### Does this PR introduce any user-facing change? no ### How was this patch tested? no need to test Closesapache#25755 from LinhongLiu/remove-todo. Authored-by: Liu,Linhong <liulinhong@baidu.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
PR #22112 fixed the todo added by PR #20393(SPARK-23207). We can remove it now.
Why are the changes needed?
In order not to confuse developers.
Does this PR introduce any user-facing change?
no
How was this patch tested?
no need to test