Uh oh!
There was an error while loading. Please reload this page.
[WIP][SPARK-2883][SQL]initial support ORC in spark sql - #2576
Conversation
AmplabJenkins
commented
Sep 29, 2014
Can one of the admins verify this patch? |
cloud-fan
commented
Sep 30, 2014
Have you considered cooperate with #2475? |
scwf
commented
Sep 30, 2014
@cloud-fan, no since #2475 has not merged to master. @marmbrus can you take a look at this? |
yhuai
commented
Sep 30, 2014
I guess we should revisit it after #2475 is in. |
There was a problem hiding this comment.
Is there a way we can depend only on ORC file and not on the entire hive-exec package? It think we'll need to move this functionality into the hive package if it requires all of the hive dependencies.
There was a problem hiding this comment.
Yeah it appears ORC has deep dependencies on Hive types. So I think this will need to be moved into the Hive project.
There was a problem hiding this comment.
Actually i also want that, but unfortunately have not found the solution
There was a problem hiding this comment.
hive project have supported ORC, this PR is to enable sql project to support it, just as it support parquet
There was a problem hiding this comment.
The whole point of having hive as a separate project is to avoid pulling in all of the dependencies of hive for all spark users. Thus, as Patrick said, this will have to go in the hive sub project. That said, I think this patch is still quite valuable. We generally recommend that all users use the HiveContext if they can tolerate hive's dependencies, so it'll still get use. Also, this patch provides better programatic API support in addition to the existing SQL support.
marmbrus
commented
Oct 1, 2014
Hey @scwf, thanks for working on this! This will be a pretty awesome feature that people have been asking for. I did a quick pass and made some comments. One higher level comment, we'll want to change this to use an API similar to #2475 as we are going to stop adding new data source methods directly to SQLContext (and we'll probably try and deprecate parquet and json from there as well eventually). I haven't had enough time to finish that PR yet (it doesn't yet support inserting data), but will try and get that merged in soon. |
yhuai
commented
Oct 1, 2014
Once #2616 is in, can we reuse stuff in |
marmbrus
commented
Oct 1, 2014
ok to test |
AmplabJenkins
commented
Oct 1, 2014
Test FAILed. |
SparkQA
commented
Oct 4, 2014
QA tests have started for PR 2576 at commit
|
AmplabJenkins
commented
Oct 4, 2014
Test FAILed. |
SparkQA
commented
Oct 4, 2014
QA tests have started for PR 2576 at commit
|
AmplabJenkins
commented
Oct 4, 2014
Test FAILed. |
This reverts commit 5f5fda8.
scwf
commented
Nov 23, 2014
Added support orc with new datasource API. Since now there is no sink interface in data source api, not remove the old version. |
SparkQA
commented
Nov 23, 2014
Test build #23756 has started for PR 2576 at commit
|
AmplabJenkins
commented
Nov 23, 2014
Test FAILed. |
There was a problem hiding this comment.
Orc files, instead of parquet files
zhzhan
commented
Dec 1, 2014
predictor pushdown support
SparkQA
commented
Dec 2, 2014
Test build #24014 has started for PR 2576 at commit
|
AmplabJenkins
commented
Dec 2, 2014
Test FAILed. |
scwf
commented
Dec 15, 2014
@marmbrus, i am fixing the test failure and refactoring the code based on datasource api, and one question here is, should i keep the sink part(write interface) here? Or just provide the ability to read orc file based on datasource api? |
marmbrus
commented
Dec 15, 2014
We are adding support for writing data in the next version of the API so probably better to wait until that is available. |
scwf
commented
Dec 21, 2014
OK, so i make #3753 to support orc based on the new datasource api. @zhzhan, in that PR it's support to read partitioned orc files but no ppd(ppd also need refactory based on the new datasource api), you can make a follow up PR for ppd after it merged or you can send the ppd support to my branch, anyway is ok. |
marmbrus
commented
Dec 30, 2014
We can close this issue right? |
scwf
commented
Dec 30, 2014
yes, closed! |
Provide a initial support for orc file formate in spark sql, support for both reading and writing ORC files . user can use ORC file just like parquet as follow: