[SPARK-29084][SQL][TESTS] Check method bytecode size in BenchmarkQueryTest

[maropu]

What changes were proposed in this pull request?

This pr proposes to check method bytecode size in BenchmarkQueryTest. This metric is critical for performance numbers.

Why are the changes needed?

For performance checks

Does this PR introduce any user-facing change?

No

How was this patch tested?

N/A

[maropu]

I found the test below in TPCDSQuerySuite fails:

- modified-q3 *** FAILED ***
12184 was not less than 8000 Found too long generated codes in the WholeStageCodegenExec subtree (id=108685) and JIT optimization might not work: the bytecode size is above the default limit of the OpenJDK HotSpot JVM:
*(1) Project [ss_sold_date_sk#340, ss_item_sk#342, ss_net_profit#362]
+- *(1) Filter ((((((((((((ss_sold_date_sk#340 >= 2415355) AND (ss_sold_date_s

That's because FileterExec could have too long generated code, so I'm digging into this.

[dongjoon-hyun]

Thank you for adding this. This looks useful.
Could you add [TESTS] into the PR title, @maropu ?
In addition, if modified-q3 still fails, could you add [WIP] on the title to prevent accidental merging this PR?

[SparkQA]

Test build #110583 has finished for PR 25788 at commit b95aaa2.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #110582 has finished for PR 25788 at commit 858d940.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[dongjoon-hyun]

Oh, is this ready, @maropu ?

[maropu]

I'm checking if all the tests passed. I persnally think we need more time for #25827 but that pr does not block this pr.

[SparkQA]

Test build #111101 has finished for PR 25788 at commit 9f32999.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[maropu]

retest this please

[SparkQA]

Test build #111104 has finished for PR 25788 at commit 9f32999.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[maropu]

ok, could you check this? @dongjoon-hyun@viirya

[dongjoon-hyun]

Of course, @maropu ~ I'll do today.

[dongjoon-hyun]

Can we have an IDed TODO to remove this, @maropu ? SPARK-29128 is the one?

[dongjoon-hyun]

Otherwise, we had better wait for the fix.

[maropu]

ok

[SparkQA]

Test build #111132 has finished for PR 25788 at commit 93448be.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[dongjoon-hyun]

+1, LGTM. Thank you, @maropu .
Although there is a blacklist query, this PR helps us a lot.
Merged to master.

[maropu]

Thanks, @dongjoon-hyun !