Uh oh!
There was an error while loading. Please reload this page.
[SPARK-28683][BUILD][FOLLOW-UP][2.4] Fix javadoc generation issue after upgrading genjavadoc to 0.14 - #25841
Closed
wangyum wants to merge 1 commit into
Closed
[SPARK-28683][BUILD][FOLLOW-UP][2.4] Fix javadoc generation issue after upgrading genjavadoc to 0.14#25841wangyum wants to merge 1 commit into
wangyum wants to merge 1 commit into
Conversation
wangyum
commented
Sep 19, 2019
MemberAuthor
dongjoon-hyun
commented
Sep 19, 2019
Member
Oh. I see. Thanks! Let me check it manually, too. |
Member
BTW, @wangyum . Is the build error correct? In your previous backporting PR and current |
dongjoon-hyun
commented
Sep 19, 2019
Member
Got it. The following? |
wangyum
commented
Sep 19, 2019
MemberAuthor
I can reproduce it by: build/sbt -Phadoop-2.7 -Pkubernetes -Phive-thriftserver -Pflume -Pkinesis-asl -Pyarn -Pkafka-0-8 -Pspark-ganglia-lgpl -Phive -Pmesos unidoc |
dongjoon-hyun
commented
Sep 19, 2019
Member
Yes. I noticed that from the previous PRs. I updated the PR title and description more specifically~ |
wangyum
commented
Sep 19, 2019
MemberAuthor
Thank you @dongjoon-hyun |
dongjoon-hyun
approved these changes
Sep 19, 2019
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM. I also verified this in branch-2.4.
dongjoon-hyun
commented
Sep 19, 2019
Member
I'll merge this because this is verified manually and currently blocks the other backporting PR. |
dongjoon-hyun pushed a commit
that referenced
this pull request
Sep 19, 2019
…er upgrading genjavadoc to 0.14 ### What changes were proposed in this pull request? This PR backport #24443 to fix java doc generation after upgrading genjavadoc to 0.14. ### Why are the changes needed? Fix javadoc generation issue. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? ``` ./build/sbt -Phadoop-2.7 -Pkubernetes -Phive-thriftserver -Pkinesis-asl -Pyarn -Pspark-ganglia-lgpl -Phive -Pmesos clean test:package streaming-kinesis-asl-assembly/assembly ./build/sbt -Phadoop-2.7 -Pkubernetes -Phive-thriftserver -Pkinesis-asl -Pyarn -Pspark-ganglia-lgpl -Phive -Pmesos unidoc ``` Closes#25841 from wangyum/genjavadoc-0.13-branch-2.4. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
SparkQA
commented
Sep 19, 2019
Test build #110958 has finished for PR 25841 at commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR backport #24443 to fix java doc generation after upgrading genjavadoc to 0.14.
Why are the changes needed?
Fix javadoc generation issue.
Does this PR introduce any user-facing change?
No.
How was this patch tested?