Skip to content

[MINOR][BUILD] Fix about 15 misc build warnings - #25852

Closed
srowen wants to merge 3 commits into
apache:masterfrom
srowen:BuildWarnings
Closed

[MINOR][BUILD] Fix about 15 misc build warnings#25852
srowen wants to merge 3 commits into
apache:masterfrom
srowen:BuildWarnings

Conversation

@srowen

@srowensrowen commented Sep 19, 2019

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This addresses about 15 miscellaneous warnings that appear in the current build.

Why are the changes needed?

No functional changes, it just slightly reduces the amount of extra warning output.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests, run manually.

@srowensrowen self-assigned this Sep 19, 2019
@SparkQA

SparkQA commented Sep 19, 2019

Copy link
Copy Markdown

Test build #110995 has finished for PR 25852 at commit d883d25.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

MaxGekk
MaxGekk reviewed Sep 19, 2019
View reviewed changes
Comment threadcore/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala Outdated

implicit val webDriver: WebDriver =
new HtmlUnitDriver(BrowserVersion.INTERNET_EXPLORER_11, true)
new HtmlUnitDriver(BrowserVersion.INTERNET_EXPLORER, true)

@MaxGekkMaxGekkSep 19, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering why Internet Explorer at all. Why not BrowserVersion.getDefault()?

@srowensrowenSep 19, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#24843 (comment) is relevant, but, I imagine any modern browser would handle the jquery JS fine too. I can try just removing this specification, as it (now) defaults to Chrome (51). I think before it emulated IE 8.

@SparkQA

SparkQA commented Sep 19, 2019

Copy link
Copy Markdown

Test build #111006 has finished for PR 25852 at commit d626bbd.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

SparkQA commented Sep 19, 2019

Copy link
Copy Markdown

Test build #111004 has finished for PR 25852 at commit 0c15bd2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

dongjoon-hyun
dongjoon-hyun approved these changes Sep 19, 2019
View reviewed changes

@dongjoon-hyundongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending Jenkins).

@SparkQA

SparkQA commented Sep 19, 2019

Copy link
Copy Markdown

Test build #4878 has finished for PR 25852 at commit d626bbd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun

dongjoon-hyun commented Sep 19, 2019

Copy link
Copy Markdown
Member

Merged to master. Thank you, @srowen and @MaxGekk .

@dongjoon-hyun

dongjoon-hyun commented Sep 19, 2019

Copy link
Copy Markdown
Member

Some of them looks relevant to branch-2.4, too.
Could you make a backporting PR please, @srowen ?

srowen added a commit to srowen/spark that referenced this pull request Sep 19, 2019
@srowen
[MINOR][BUILD] Fix about 15 misc build warnings
4d7457c
This addresses about 15 miscellaneous warnings that appear in the current build.
No functional changes, it just slightly reduces the amount of extra warning output.
No.
Existing tests, run manually.
Closesapache#25852 from srowen/BuildWarnings.
Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@srowensrowen mentioned this pull request Sep 19, 2019
Closed
@srowen

srowen commented Sep 19, 2019

Copy link
Copy Markdown
MemberAuthor

Sure, only a handful affected 2.4: #25857

dongjoon-hyun pushed a commit that referenced this pull request Sep 20, 2019
@srowen@dongjoon-hyun
[MINOR][BUILD][2.4] Fix 4 misc build warnings
71b0562
This addresses 4 miscellaneous warnings that appear in the current build.
Back-port of some of #25852Closes#25857 from srowen/BuildWarnings2.4.
Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@srowen
srowen deleted the BuildWarnings branch September 27, 2019 04:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxGekkMaxGekkMaxGekk left review comments
@dongjoon-hyundongjoon-hyundongjoon-hyun approved these changes

Assignees

@srowensrowen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@srowen@SparkQA@dongjoon-hyun@MaxGekk