Uh oh!
There was an error while loading. Please reload this page.
[SPARK-19926][PYSPARK][Followup] Add unicode for flake8 check - #25858
Closed
viirya wants to merge 1 commit into
Closed
[SPARK-19926][PYSPARK][Followup] Add unicode for flake8 check#25858viirya wants to merge 1 commit into
viirya wants to merge 1 commit into
Conversation
viirya
commented
Sep 19, 2019
MemberAuthor
SparkQA
commented
Sep 19, 2019
Test build #111026 has finished for PR 25858 at commit
|
viirya
commented
Sep 19, 2019
MemberAuthor
@dongjoon-hyun@srowen Can you check if this looks good for you. thanks. |
viirya
commented
Sep 19, 2019
MemberAuthor
close this as @advancedxy responses to original PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow up to add unicode alias for Python3 in order to pass flake8 check. This is to address the comment #25814 (comment).
Why are the changes needed?
Without this, flake8 on Python3 will report error, because it can not find unicode definition.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manual check on local