Skip to content

[SPARK-29255][SQL][TESTS] Rename package pgSQL to postgreSQL - #25936

Closed
gengliangwang wants to merge 2 commits into
apache:masterfrom
gengliangwang:renamePGSQL
Closed

[SPARK-29255][SQL][TESTS] Rename package pgSQL to postgreSQL#25936
gengliangwang wants to merge 2 commits into
apache:masterfrom
gengliangwang:renamePGSQL

Conversation

@gengliangwang

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Rename the package pgSQL to postgreSQL

Why are the changes needed?

To address the comment in #25697 (comment) . The official full name seems more reasonable.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing unit tests.

@maropu

Copy link
Copy Markdown
Member

Looks ok to me. also cc: @dongjoon-hyun@HyukjinKwon

@SparkQA

Copy link
Copy Markdown

Test build #111397 has finished for PR 25936 at commit fbffe34.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gengliangwang

Copy link
Copy Markdown
MemberAuthor

retest this please.

@dongjoon-hyun

Copy link
Copy Markdown
Member

@gengliangwang . Could you handle the followings together?

$ git grep pgSQL
sql/core/src/test/resources/sql-tests/inputs/udf/postgreSQL/udf-aggregates_part1.sql:-- This test file was converted from pgSQL/aggregates_part1.sql.
sql/core/src/test/resources/sql-tests/inputs/udf/postgreSQL/udf-aggregates_part2.sql:-- This test file was converted from pgSQL/aggregates_part2.sql.
sql/core/src/test/resources/sql-tests/inputs/udf/postgreSQL/udf-aggregates_part3.sql:-- This test file was converted from pgSQL/aggregates_part3.sql.
sql/core/src/test/resources/sql-tests/inputs/udf/postgreSQL/udf-aggregates_part4.sql:-- This test file was converted from pgSQL/aggregates_part4.sql.
sql/core/src/test/resources/sql-tests/inputs/udf/postgreSQL/udf-case.sql:-- This test file was converted from pgSQL/case.sql.
sql/core/src/test/resources/sql-tests/inputs/udf/postgreSQL/udf-join.sql:-- This test file was converted from pgSQL/join.sql.
sql/core/src/test/resources/sql-tests/inputs/udf/postgreSQL/udf-select_having.sql:-- This test file was converted from inputs/pgSQL/select_having.sql
sql/core/src/test/resources/sql-tests/inputs/udf/postgreSQL/udf-select_implicit.sql:-- This test file was converted from pgSQL/select_implicit.sql

@dongjoon-hyundongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM except only the above minor request (changing the path in sql script comment consistently).

@HyukjinKwonHyukjinKwon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too except @dongjoon-hyun's comments

@gengliangwang

Copy link
Copy Markdown
MemberAuthor

@dongjoon-hyun Thanks for the suggestion.
The output of git grep pgSQL is now empty.

@SparkQA

Copy link
Copy Markdown

Test build #111399 has finished for PR 25936 at commit fbffe34.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

Copy link
Copy Markdown

Test build #111412 has finished for PR 25936 at commit 18be34f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum

Copy link
Copy Markdown
Member

Merged to master.

@dongjoon-hyun

Copy link
Copy Markdown
Member

Thank you all!

@maropu

Copy link
Copy Markdown
Member

Thanks, @gengliangwang !

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@gengliangwang@maropu@SparkQA@dongjoon-hyun@wangyum@HyukjinKwon