Uh oh!
There was an error while loading. Please reload this page.
[SPARK-29107][SQL][TESTS] Port window.sql (Part 1) - #26119
Conversation
Signed-off-by: DylanGuedes <djmgguedes@gmail.com>
dongjoon-hyun
commented
Oct 15, 2019
ok to test |
dongjoon-hyun
commented
Oct 15, 2019
Thank you, @DylanGuedes ! |
dongjoon-hyun
commented
Oct 15, 2019
SparkQA
commented
Oct 15, 2019
Test build #112081 has finished for PR 26119 at commit
|
gengliangwang
commented
Oct 15, 2019
@DylanGuedes Thanks for the work. |
dongjoon-hyun
commented
Oct 15, 2019
#26107 is merged. Thanks, @gengliangwang . |
dongjoon-hyun
commented
Oct 15, 2019
Retest this please. |
SparkQA
commented
Oct 15, 2019
Test build #112123 has finished for PR 26119 at commit
|
dongjoon-hyun
commented
Oct 15, 2019
According to the failures, we need to update the PR. |
DylanGuedes
commented
Oct 16, 2019
@dongjoon-hyun should I JIRA that? |
Signed-off-by: DylanGuedes <djmgguedes@gmail.com>
SparkQA
commented
Oct 16, 2019
Test build #112130 has finished for PR 26119 at commit
|
HyukjinKwon
commented
Oct 21, 2019
@DylanGuedes, please skip or fix the tests being failed in the thrift server. cc @wangyum |
DylanGuedes
commented
Oct 22, 2019
@HyukjinKwon I have no idea why they are breaking on Thrift, they used to pass in the older PR and they also were fine in my local config (I can't rerun then now because my environment suddenly broken). Do you have any suggestion? I don't think that makes sense to just comment out anything related to date since |
Signed-off-by: DylanGuedes <djmgguedes@gmail.com>
SparkQA
commented
Oct 22, 2019
Test build #112420 has finished for PR 26119 at commit
|
HyukjinKwon
commented
Oct 22, 2019
You can either skip the single test with a comment or add it in a blacklist I think cc @wangyum |
Signed-off-by: DylanGuedes <djmgguedes@gmail.com>
HyukjinKwon
left a comment
There was a problem hiding this comment.
Looks fine to me. I will merge in few days.
SparkQA
commented
Oct 22, 2019
Test build #112422 has finished for PR 26119 at commit
|
HyukjinKwon
commented
Oct 23, 2019
Merged to master. |
maropu
commented
Oct 23, 2019
Thanks for the work, @DylanGuedes! btw, how many PR parts are left for window.sql? It seems we have no open PRs for this. |
DylanGuedes
commented
Oct 23, 2019
@maropu Two parts are missing. I thought that there were more people interested on working on them because I read some comments on JIRA, but since no one opened a MR, I'll create a new one for the other parts and work them as well. |
maropu
commented
Oct 24, 2019
Thanks, again! |
What changes were proposed in this pull request?
This PR ports window.sql from PostgreSQL regression tests https://github.com/postgres/postgres/blob/REL_12_STABLE/src/test/regress/sql/window.sql from lines 1~319
The expected results can be found in the link: https://github.com/postgres/postgres/blob/REL_12_STABLE/src/test/regress/expected/window.out
Why are the changes needed?
To ensure compatibility with PostgreSQL.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass the Jenkins. And, Comparison with PgSQL results.