Uh oh!
There was an error while loading. Please reload this page.
[SPARK-29524][SQL] Support unordered interval units in casting from strings - #26180
[SPARK-29524][SQL] Support unordered interval units in casting from strings#26180MaxGekk wants to merge 2 commits into
Conversation
SparkQA
commented
Oct 20, 2019
Test build #112339 has finished for PR 26180 at commit
|
MaxGekk
commented
Oct 20, 2019
@cloud-fan Please, take a look at it. |
Let's wait for #26190 first. I'm not sure it's the right direction to keep improving the hand-written regex-based parser instead of using antlr. |
MaxGekk
commented
Oct 21, 2019
@cloud-fan WDYT about modifying it to support |
cloud-fan
commented
Oct 22, 2019
that sounds good! |
MaxGekk
commented
Oct 22, 2019
ok. I will close this PR, and will try to implement interval parsing from |
MaxGekk
commented
Oct 25, 2019
@cloud-fan Here is the PR #26256 for |
What changes were proposed in this pull request?
In the PR, I propose to replace existing implementation of
CalendarInterval.fromCaseInsensitiveStringbased on a regexp by another implementation using finite state machine. The existing regex assumes particular order of interval units fromYEARtoMICROSECOND. Modification of the regexp becomes very hard to support new features.Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
CalendarIntervalSuiteddayCalendarIntervalSuite