[SPARK-29453][WEBUI] Improve tooltips information for SQL tab. by 07ARB · Pull Request #26216 · apache/spark

07ARB · 2019-10-22T20:41:33Z

What changes were proposed in this pull request?

Adding tooltip to SQL tab for better usability.

Why are the changes needed?

There are a few common points of confusion in the UI that could be clarified with tooltips. We should add tooltips to explain.

Does this PR introduce any user-facing change?

Yes.

How was this patch tested?

Unit tests (written unit test cases to verify changes).
Manual test.

07ARB · 2019-10-22T20:45:37Z

07ARB · 2019-10-22T20:51:13Z

@AmplabJenkins ,Thank you , please help me to review my PR.

dongjoon-hyun · 2019-10-22T21:20:34Z

Thank you for your contribution, @07ARB . I updated the PR title. You can see the available labels here (https://github.com/apache/spark/labels). We need to use use WEBUI tag.

dongjoon-hyun · 2019-10-22T21:20:50Z

ok to test

SparkQA · 2019-10-22T21:24:17Z

Test build #112489 has finished for PR 26216 at commit bd6b62f.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

07ARB · 2019-10-22T21:25:01Z

@dongjoon-hyun Thank you, from next time onward I will remember to use correct labels.

SparkQA · 2019-10-23T01:20:48Z

Test build #112490 has finished for PR 26216 at commit ebef6d6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

shahidki31 · 2019-10-23T05:42:23Z

retest this please

07ARB · 2019-10-23T06:15:43Z

ok

dongjoon-hyun · 2019-10-23T06:19:06Z

@07ARB . I updated the PR description a little.

07ARB · 2019-10-23T06:53:52Z

@dongjoon-hyun,@shahidki31 Thank you, i will work on given comments and will raise PR again.If any other suggestion please write it.

SparkQA · 2019-10-23T07:05:02Z

Test build #112512 has finished for PR 26216 at commit ebef6d6.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2019-10-23T11:06:48Z

Test build #112537 has finished for PR 26216 at commit 7123a2f.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

### What changes were proposed in this pull request? Adding tooltip to SQL tab for better usability. https://issues.apache.org/jira/browse/SPARK-29453 ### Why are the changes needed? There are a few common points of confusion in the UI that could be clarified with tooltips. We should add tooltips to explain. ### Does this PR introduce any user-facing change? yes. ### How was this patch tested? 1) Unit tests (written unit test cases to verify changes). 2) Manual test. Authored-by: Ankit Raj Boudh <ankitrajboudh@gmail.com> Remove tab character from file. modify code as per the review comments. fixed all the review comments fixed all the review comments

SparkQA · 2019-10-23T19:25:42Z

Test build #112553 has finished for PR 26216 at commit 811083a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

07ARB · 2019-10-23T21:10:30Z

@dongjoon-hyun,@HeartSaVioR and @shahidki31 please review the latest changes.

SparkQA · 2019-10-23T21:16:44Z

Test build #112556 has finished for PR 26216 at commit cbcab45.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

07ARB · 2019-10-24T03:45:42Z

screenshot after fixed all the review comments

### What changes were proposed in this pull request? Adding tooltip to SQL tab for better usability. https://issues.apache.org/jira/browse/SPARK-29453 ### Why are the changes needed? There are a few common points of confusion in the UI that could be clarified with tooltips. We should add tooltips to explain. ### Does this PR introduce any user-facing change? yes. ### How was this patch tested? 1) Unit tests (written unit test cases to verify changes). 2) Manual test. Authored-by: Ankit Raj Boudh <ankitrajboudh@gmail.com> Remove tab character from file. modify code as per the review comments. fixed all the review comments fixed all the review comments fixed review comments

…RK-29453 # Conflicts: # sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala

srowen

I don't think it hurts, but I don't think this adds much

### What changes were proposed in this pull request? Adding tooltip to SQL tab for better usability. https://issues.apache.org/jira/browse/SPARK-29453 ### Why are the changes needed? There are a few common points of confusion in the UI that could be clarified with tooltips. We should add tooltips to explain. ### Does this PR introduce any user-facing change? yes. ### How was this patch tested? 1) Unit tests (written unit test cases to verify changes). 2) Manual test. Authored-by: Ankit Raj Boudh <ankitrajboudh@gmail.com> Remove tab character from file. modify code as per the review comments. fixed all the review comments fixed all the review comments fixed review comments.

…RK-29453 # Conflicts: # sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala

SparkQA · 2019-10-25T14:15:24Z

Test build #112670 has finished for PR 26216 at commit e958370.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2019-10-25T16:49:57Z

Test build #112666 has finished for PR 26216 at commit 0eeb5df.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2019-10-25T17:30:55Z

Test build #112668 has finished for PR 26216 at commit 0d5062f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

dongjoon-hyun added the WEB UI label Oct 22, 2019

dongjoon-hyun changed the title ~~[SPARK-29453][SQL TAB] Improve tooltips information for SQL tab.~~[SPARK-29453][WEBUI] Improve tooltips information for SQL tab.Oct 22, 2019

07ARB force-pushed the SPARK-29453 branch from bd6b62f to ebef6d6Compare October 22, 2019 22:37

shahidki31 reviewed Oct 23, 2019
View reviewed changes

Comment threadsql/core/src/test/scala/org/apache/spark/sql/execution/ui/AllExecutionsPageSuite.scala Outdated
Comment threadsql/core/src/main/scala/org/apache/spark/sql/execution/ui/ToolTips.scala Outdated

dongjoon-hyun reviewed Oct 23, 2019
View reviewed changes

Comment threadsql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala Outdated

dongjoon-hyun reviewed Oct 23, 2019
View reviewed changes

Comment threadsql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala Outdated

dongjoon-hyun reviewed Oct 23, 2019
View reviewed changes

Comment threadsql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala Outdated

dongjoon-hyun reviewed Oct 23, 2019
View reviewed changes

Comment threadsql/core/src/test/scala/org/apache/spark/sql/execution/ui/AllExecutionsPageSuite.scala Outdated

dongjoon-hyun reviewed Oct 23, 2019
View reviewed changes

Comment threadsql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala Outdated

shahidki31 reviewed Oct 23, 2019
View reviewed changes

Comment threadsql/core/src/main/scala/org/apache/spark/sql/execution/ui/ToolTips.scala Outdated
Comment threadsql/core/src/main/scala/org/apache/spark/sql/execution/ui/ToolTips.scala Outdated

07ARB force-pushed the SPARK-29453 branch from ebef6d6 to 7123a2fCompare October 23, 2019 10:55

07ARB requested a review from dongjoon-hyun October 23, 2019 10:57

shahidki31 reviewed Oct 23, 2019
View reviewed changes

Comment threadcore/src/main/scala/org/apache/spark/ui/UIUtils.scala Outdated

shahidki31 reviewed Oct 23, 2019
View reviewed changes

Comment threadsql/core/src/test/scala/org/apache/spark/sql/execution/ui/AllExecutionsPageSuite.scala Outdated

07ARB force-pushed the SPARK-29453 branch from 7123a2f to 811083aCompare October 23, 2019 16:55

07ARB force-pushed the SPARK-29453 branch from 811083a to cbcab45Compare October 23, 2019 17:38

shahidki31 reviewed Oct 24, 2019
View reviewed changes

Comment threadsql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala Outdated

dongjoon-hyun reviewed Oct 24, 2019
View reviewed changes

Comment threadsql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala