Skip to content

[SPARK-29453][WEBUI] Improve tooltips information for SQL tab. - #26641

Closed
07ARB wants to merge 1 commit into
apache:masterfrom
07ARB:SPARK-29453
Closed

[SPARK-29453][WEBUI] Improve tooltips information for SQL tab.#26641
07ARB wants to merge 1 commit into
apache:masterfrom
07ARB:SPARK-29453

Conversation

@07ARB

@07ARB07ARB commented Nov 22, 2019

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Adding tooltip to SQL tab for better usability.

Why are the changes needed?

There are a few common points of confusion in the UI that could be clarified with tooltips. We
should add tooltips to explain.

Does this PR introduce any user-facing change?

yes.
Screenshot 2019-11-23 at 9 47 41 AM

How was this patch tested?

Manual test.

@07ARB

Copy link
Copy Markdown
ContributorAuthor

@srowen , please review this PR, i have modifed code as per your suggestion.#26259

@07ARB

Copy link
Copy Markdown
ContributorAuthor

@srowen , if this PR is ok , then please merge it to master.

@SparkQA

Copy link
Copy Markdown

Test build #4944 has finished for PR 26641 at commit 2df1f20.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

Copy link
Copy Markdown

Test build #4948 has finished for PR 26641 at commit 2df1f20.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@07ARB

Copy link
Copy Markdown
ContributorAuthor

@srowen , Thank you , for your good guidance, your guidance will motivate me to contribute more in spark community.

@07ARB

Copy link
Copy Markdown
ContributorAuthor

I checked failure test cases not related to this PR

@07ARB
07ARB requested a review from srowenNovember 29, 2019 14:13
@SparkQA

Copy link
Copy Markdown

Test build #4953 has finished for PR 26641 at commit 2df1f20.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

Copy link
Copy Markdown

Test build #4954 has finished for PR 26641 at commit 2df1f20.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

Copy link
Copy Markdown

Test build #4956 has finished for PR 26641 at commit 2df1f20.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

Copy link
Copy Markdown

Test build #4959 has finished for PR 26641 at commit 2df1f20.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen

Copy link
Copy Markdown
Member

Hm, I really can't figure out why those tests are failing. It looks clearly unrelated, but consistent. And I don't see the failure in other PR builds that seem to touch sql/core.

@07ARB

07ARB commented Dec 3, 2019

Copy link
Copy Markdown
ContributorAuthor

@srowen ,No problem i will check why it's failing.

@HyukjinKwon

Copy link
Copy Markdown
Member

retest this please

@SparkQA

Copy link
Copy Markdown

Test build #114810 has finished for PR 26641 at commit 2df1f20.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@07ARB

07ARB commented Dec 4, 2019

Copy link
Copy Markdown
ContributorAuthor

@HyukjinKwon , Thank you

@07ARB

07ARB commented Dec 4, 2019

Copy link
Copy Markdown
ContributorAuthor

@srowen , all test passed , i think now it's ok

@srowensrowen closed this in a2102c8Dec 4, 2019
@srowen

Copy link
Copy Markdown
Member

Merged to master

attilapiros pushed a commit to attilapiros/spark that referenced this pull request Dec 6, 2019
### What changes were proposed in this pull request?
Adding tooltip to SQL tab for better usability.
### Why are the changes needed?
There are a few common points of confusion in the UI that could be clarified with tooltips. We
should add tooltips to explain.
### Does this PR introduce any user-facing change?
yes.
![Screenshot 2019-11-23 at 9 47 41 AM](https://user-images.githubusercontent.com/8948111/69472963-aaec5980-0dd6-11ea-881a-fe6266171054.png)
### How was this patch tested?
Manual test.
Closesapache#26641 from 07ARB/SPARK-29453.
Authored-by: 07ARB <ankitrajboudh@gmail.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@07ARB@SparkQA@srowen@HyukjinKwon@dongjoon-hyun