Uh oh!
There was an error while loading. Please reload this page.
[SPARK-30025][Core] Continuous shuffle block fetching should be disabled by default when the old fetch protocol is used - #26663
Conversation
cloud-fan
commented
Nov 25, 2019
just for curiosity, how things can go wrong if we do batch fetch with old shuffle protocol? the shuffle server can't recognize the new request and fail? |
SparkQA
commented
Nov 25, 2019
Test build #114403 has finished for PR 26663 at commit
|
That's the scenario Yuming met at https://github.com/apache/spark/pull/26147/files#r348943508. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
SparkQA
commented
Nov 26, 2019
Test build #114450 has finished for PR 26663 at commit
|
ba84e6a to
892da74CompareSparkQA
commented
Nov 29, 2019
Test build #114620 has finished for PR 26663 at commit
|
892da74 to
9c53b4aCompareSparkQA
commented
Dec 2, 2019
Test build #114703 has finished for PR 26663 at commit
|
cloud-fan
commented
Dec 2, 2019
thanks, merging to master! |
xuanyuanking
commented
Dec 2, 2019
Thanks! |
…led by default when the old fetch protocol is used ### What changes were proposed in this pull request? Disable continuous shuffle block fetching when the old fetch protocol in use. ### Why are the changes needed? The new feature of continuous shuffle block fetching depends on the latest version of the shuffle fetch protocol. We should keep this constraint in `BlockStoreShuffleReader.fetchContinuousBlocksInBatch`. ### Does this PR introduce any user-facing change? Users will not get the exception related to continuous shuffle block fetching when old version of the external shuffle service is used. ### How was this patch tested? Existing UT. Closesapache#26663 from xuanyuanking/SPARK-30025. Authored-by: Yuanjian Li <xyliyuanjian@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
What changes were proposed in this pull request?
Disable continuous shuffle block fetching when the old fetch protocol in use.
Why are the changes needed?
The new feature of continuous shuffle block fetching depends on the latest version of the shuffle fetch protocol. We should keep this constraint in
BlockStoreShuffleReader.fetchContinuousBlocksInBatch.Does this PR introduce any user-facing change?
Users will not get the exception related to continuous shuffle block fetching when old version of the external shuffle service is used.
How was this patch tested?
Existing UT.