Uh oh!
There was an error while loading. Please reload this page.
[SPARK-30093][SQL] Improve error message for creating view - #26731
Closed
amanomer wants to merge 4 commits into
Closed
[SPARK-30093][SQL] Improve error message for creating view#26731amanomer wants to merge 4 commits into
amanomer wants to merge 4 commits into
Conversation
amanomer
commented
Dec 2, 2019
ContributorAuthor
cc @gatorsmile |
amanomer
commented
Dec 3, 2019
ContributorAuthor
| // temporary views are only stored in the session catalog | ||
| throw new AnalysisException(s"Not allowed to create a permanent view $name by " + | ||
| s"referencing a temporary view $ident") | ||
| s"referencing a temporary view $ident (use TEMPORARY keyword)") |
Contributor
There was a problem hiding this comment.
nit: ... referencing a temporary view $ident. Please create a temp view instead by CREATE TEMP VIEW
amanomer
commented
Dec 3, 2019
ContributorAuthor
Jenkins, test this please. |
amanomer
commented
Dec 4, 2019
ContributorAuthor
cc @cloud-fan |
cloud-fan
commented
Dec 4, 2019
Contributor
ok to test |
SparkQA
commented
Dec 4, 2019
Test build #114858 has finished for PR 26731 at commit
|
SparkQA
commented
Dec 4, 2019
Test build #114865 has finished for PR 26731 at commit
|
amanomer
commented
Dec 5, 2019
ContributorAuthor
cc @cloud-fan |
cloud-fan
commented
Dec 5, 2019
Contributor
thanks, merging to master! |
attilapiros pushed a commit
to attilapiros/spark
that referenced
this pull request
Dec 6, 2019
### What changes were proposed in this pull request? Improved error message while creating views. ### Why are the changes needed? Error message should suggest user to use TEMPORARY keyword while creating permanent view referred by temporary view. apache#26317 (comment) ### Does this PR introduce any user-facing change? No ### How was this patch tested? Updated test case. Closesapache#26731 from amanomer/imp_err_msg. Authored-by: Aman Omer <amanomer1996@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improved error message while creating views.
Why are the changes needed?
Error message should suggest user to use TEMPORARY keyword while creating permanent view referred by temporary view.
#26317 (comment)
Does this PR introduce any user-facing change?
No
How was this patch tested?
Updated test case.