Uh oh!
There was an error while loading. Please reload this page.
[SPARK-30112][SQL] Allow insert overwrite same table if using dynamic partition overwrite - #26752
Closed
viirya wants to merge 3 commits into
Closed
[SPARK-30112][SQL] Allow insert overwrite same table if using dynamic partition overwrite#26752viirya wants to merge 3 commits into
viirya wants to merge 3 commits into
Conversation
viirya
commented
Dec 4, 2019
MemberAuthor
cc @cloud-fan |
SparkQA
commented
Dec 4, 2019
Test build #114806 has finished for PR 26752 at commit
|
viiryaforce-pushed
the
dynamic-overwrite-same-table
branch
from
December 4, 2019 04:47
e5f4122 to
378fbc4CompareSparkQA
commented
Dec 4, 2019
Test build #114827 has finished for PR 26752 at commit
|
viirya
commented
Dec 4, 2019
MemberAuthor
retest this please. |
SparkQA
commented
Dec 4, 2019
Test build #114840 has finished for PR 26752 at commit
|
dongjoon-hyun
commented
Dec 6, 2019
Member
Retest this please. |
dongjoon-hyun
commented
Dec 6, 2019
Member
Thank you for making a PR for this issue. |
| test("it is allowed to write to a table while querying it for dynamic partition overwrite.") { | ||
| Seq(PartitionOverwriteMode.DYNAMIC.toString, | ||
| PartitionOverwriteMode.STATIC.toString).foreach { usedMode => |
| """ | ||
| |CREATE TABLE insertTable(i int, part1 int, part2 int) USING PARQUET | ||
| |PARTITIONED BY (part1, part2) | ||
| """.stripMargin) |
| """ | ||
| |INSERT OVERWRITE TABLE insertTable PARTITION(part1=1, part2) | ||
| |SELECT i + 1, part2 FROM insertTable | ||
| """.stripMargin) |
Uh oh!
There was an error while loading. Please reload this page.
SparkQA
commented
Dec 6, 2019
Test build #114920 has finished for PR 26752 at commit
|
SparkQA
commented
Dec 6, 2019
Test build #114921 has finished for PR 26752 at commit
|
dongjoon-hyun
commented
Dec 6, 2019
Member
cc @cloud-fan |
| private lazy val parameters = CaseInsensitiveMap(options) | ||
| private[sql] lazy val dynamicPartitionOverwriteEnabled: Boolean = { |
Contributor
There was a problem hiding this comment.
shall we just name it dynamicPartitionOverwrite? then we can remove https://github.com/apache/spark/pull/26752/files#diff-f9858c2d9d1a3c3e48753ef675bc865aR109
| "INSERT OVERWRITE to a table while querying it should not be allowed.") | ||
| } | ||
| test("it is allowed to write to a table while querying it for dynamic partition overwrite.") { |
cloud-fan
approved these changes
Dec 6, 2019
dongjoon-hyun
approved these changes
Dec 6, 2019
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM. Merged to master.
Thank you so much, @viirya and @cloud-fan .
I also verified the last commit manually.
SparkQA
commented
Dec 6, 2019
Test build #114956 has finished for PR 26752 at commit
|
viirya
commented
Dec 6, 2019
MemberAuthor
thanks! @cloud-fan@dongjoon-hyun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch proposes to allow insert overwrite same table if using dynamic partition overwrite.
Why are the changes needed?
Currently, Insert overwrite cannot overwrite to same table even it is dynamic partition overwrite. But for dynamic partition overwrite, we do not delete partition directories ahead. We write to staging directories and move data to final partition directories. We should be able to insert overwrite to same table under dynamic partition overwrite.
This enables users to read data from a table and insert overwrite to same table by using dynamic partition overwrite. Because this is not allowed for now, users need to write to other temporary location and move it back to the table.
Does this PR introduce any user-facing change?
Yes. Users can insert overwrite same table if using dynamic partition overwrite.
How was this patch tested?
Unit test.