Uh oh!
There was an error while loading. Please reload this page.
[SPARK-30309][SQL] Mark Filter as a sealed class - #26950
Closed
MaxGekk wants to merge 1 commit into
Closed
Conversation
MaxGekk
commented
Dec 19, 2019
MemberAuthor
ping @hvanhovell |
| */ | ||
| @Stable | ||
| abstract class Filter { | ||
| sealed abstract class Filter { |
There was a problem hiding this comment.
Hi, @MaxGekk . Please file a JIRA for this.
Filter as a sealed classFilter as a sealed classSparkQA
commented
Dec 19, 2019
Test build #115573 has finished for PR 26950 at commit
|
dongjoon-hyun
approved these changes
Dec 19, 2019
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM. Merged to master. Thank you, @MaxGekk .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added the
sealedkeyword to theFilterclassWhy are the changes needed?
To do not miss handling of new filters in a datasource in the future. For example,
AlwaysTrueandAlwaysFalsewere added recently by #23606Does this PR introduce any user-facing change?
Should not.
How was this patch tested?
By existing tests.