Uh oh!
There was an error while loading. Please reload this page.
[SPARK-30128][DOCS][PYTHON][SQL] Document/promote 'recursiveFileLookup' and 'pathGlobFilter' in file sources 'mergeSchema' in ORC - #26958
Closed
HyukjinKwon wants to merge 2 commits into
Closed
Conversation
…mergeSchema' in ORC
MemberAuthor
Let me just cc everybody involved in those PRs and JIRAs. @nchammas, @gengliangwang, @WeichenXu123, @WangGuangxin, @dongjoon-hyun, @gatorsmile, @cloud-fan, @Ngone51, @mengxr |
nchammas
commented
Dec 20, 2019
Contributor
Uh oh!
There was an error while loading. Please reload this page.
HyukjinKwon
commented
Dec 20, 2019
| * | ||
| * You can set the following ORC-specific option(s) for reading ORC files: | ||
| * <ul> | ||
| * <li>`mergeSchema` (default is the value specified in `spark.sql.orc.mergeSchema`): sets whether |
MemberAuthor
There was a problem hiding this comment.
@nchammas, I wanted to mention this in Scala side too in the PR title.
SparkQA
commented
Dec 20, 2019
Test build #115602 has finished for PR 26958 at commit
|
SparkQA
commented
Dec 20, 2019
Test build #115600 has finished for PR 26958 at commit
|
HyukjinKwon
commented
Dec 20, 2019
MemberAuthor
retest this please |
SparkQA
commented
Dec 20, 2019
Test build #115615 has finished for PR 26958 at commit
|
HyukjinKwon
commented
Dec 22, 2019
MemberAuthor
Let me merge this in few days if you guys are fine since it's just a doc change. |
HyukjinKwon
commented
Dec 23, 2019
MemberAuthor
Thanks all. Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds and exposes the options, 'recursiveFileLookup' and 'pathGlobFilter' in file sources 'mergeSchema' in ORC, into documentation.
recursiveFileLookupat file sources: [SPARK-27990][SQL][ML] Provide a way to recursively load data from datasource #24830 (SPARK-27627)pathGlobFilterat file sources: [SPARK-27627][SQL] Make option "pathGlobFilter" as a general option for all file sources #24518 (SPARK-27990)mergeSchemaat ORC: [SPARK-11412][SQL] Support merge schema for ORC #24043 (SPARK-11412)Note that
timeZoneoption was not moved fromDataFrameReader.optionsas I assume it will likely affect other datasources as well once DSv2 is complete.Why are the changes needed?
To document available options in sources properly.
Does this PR introduce any user-facing change?
In PySpark,
pathGlobFiltercan be set viaDataFrameReader.(text|orc|parquet|json|csv)andDataStreamReader.(text|orc|parquet|json|csv).How was this patch tested?
Manually built the doc and checked the output. Option setting in PySpark is rather a logical change. I manually tested one only: