Uh oh!
There was an error while loading. Please reload this page.
[MINOR][SQL][SS] Remove TODO comments as var in case class is discouraged but worth breaking it - #26992
Closed
HeartSaVioR wants to merge 1 commit into
Closed
[MINOR][SQL][SS] Remove TODO comments as var in case class is discouraged but worth breaking it#26992HeartSaVioR wants to merge 1 commit into
HeartSaVioR wants to merge 1 commit into
Conversation
SparkQA
commented
Dec 24, 2019
Test build #115669 has finished for PR 26992 at commit
|
HyukjinKwon
approved these changes
Dec 24, 2019
srowen
commented
Dec 24, 2019
Member
Seems OK, but you will no longer have an implementation of equals, hashCode, etc. Would those be important here? not sure |
HeartSaVioR
commented
Dec 24, 2019
ContributorAuthor
Good point, and I'm seeing a spot logging out the FetchData instance which should have toString implementation (at least). If we don't feel pretty bad on having vars in case classes we may just remove the TODO comments and leave them as they are. (The PR can be changed to MINOR then.) WDYT? |
HyukjinKwon
commented
Dec 25, 2019
Member
Okay, shell we just remove todos then? |
… but worth breaking it
HeartSaVioRforce-pushed
the
SPARK-30337
branch
from
December 25, 2019 11:59
fa7652a to
7495983CompareHeartSaVioR
commented
Dec 25, 2019
ContributorAuthor
Yes, removed the TODO comments instead. |
SparkQA
commented
Dec 25, 2019
Test build #115769 has finished for PR 26992 at commit
|
HyukjinKwon
approved these changes
Dec 26, 2019
HyukjinKwon
commented
Dec 26, 2019
Member
Merged to master. |
HeartSaVioR
commented
Dec 26, 2019
ContributorAuthor
Thanks for reviewing and merging! |
fqaiser94 pushed a commit
to fqaiser94/spark
that referenced
this pull request
Mar 30, 2020
…aged but worth breaking it ### What changes were proposed in this pull request? This patch removes TODO comments which are left to address changing case classes having vars to normal classes in spark-sql-kafka module - the pattern is actually discouraged, but still worth to break it, as we already use automatic toString implementation and we may be using more. ### Why are the changes needed? Described above. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Existing UTs. Closesapache#26992 from HeartSaVioR/SPARK-30337. Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan.opensource@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch removes TODO comments which are left to address changing case classes having vars to normal classes in spark-sql-kafka module - the pattern is actually discouraged, but still worth to break it, as we already use automatic toString implementation and we may be using more.
Why are the changes needed?
Described above.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.